Add ports library route and stabilize native port indexing

joeblack2k · joeblack2k · commit cb5af80a92f7 · 2026-05-10T20:24:45.000+02:00
diff --git a/backend/cmd/server/native_ports_test.go b/backend/cmd/server/native_ports_test.go
@@ -52,6 +52,19 @@ func TestNativePortUploadUsesPortsTrackAndManifestMetadata(t *testing.T) {
 		t.Fatalf("expected origin system metadata: %s", prettyJSON(found))
 	}
 
+	portsOnly := h.request(http.MethodGet, "/saves?systemSlug=ports&limit=10", nil)
+	assertStatus(t, portsOnly, http.StatusOK)
+	portsBody := decodeJSONMap(t, portsOnly.Body)
+	if total := int(mustNumber(t, portsBody["total"], "ports.total")); total != 1 {
+		t.Fatalf("expected one filtered native port save, got %d: %s", total, prettyJSON(portsBody))
+	}
+	n64Only := h.request(http.MethodGet, "/saves?systemSlug=n64&limit=10", nil)
+	assertStatus(t, n64Only, http.StatusOK)
+	n64Body := decodeJSONMap(t, n64Only.Body)
+	if total := int(mustNumber(t, n64Body["total"], "n64.total")); total != 0 {
+		t.Fatalf("expected native port save to stay isolated from n64 list, got %d: %s", total, prettyJSON(n64Body))
+	}
+
 	latest := h.request(http.MethodGet, "/save/latest?romSha1=port:ship-of-harkinian&slotName="+url.QueryEscape("file1"), nil)
 	assertStatus(t, latest, http.StatusOK)
 	latestBody := decodeJSONMap(t, latest.Body)
@@ -83,3 +96,55 @@ func TestNativePortUploadRejectsUnmanifestedPath(t *testing.T) {
 		t.Fatalf("expected manifest rejection reason: %s", prettyJSON(body))
 	}
 }
+
+func TestNativePortUploadAllowsManifestDefaultFilename(t *testing.T) {
+	h := newContractHarness(t)
+
+	payload := make([]byte, 512)
+	payload[0] = 0x4d
+	payload[1] = 0x4b
+
+	body := uploadSave(t, h, "/saves", map[string]string{
+		"system":           "ports",
+		"rom_sha1":         "port:spaghettikart",
+		"slotName":         "default",
+		"runtimeProfile":   "port/spaghettikart",
+		"portId":           "spaghettikart",
+		"portName":         "Mario Kart 64 (SpaghettiKart)",
+		"originSystemSlug": "n64",
+		"portSaveKind":     "progress",
+		"relativePath":     "default.sav",
+		"rootRelativePath": "MarioKart64/default.sav",
+		"slotId":           "default",
+		"displayTitle":     "Mario Kart 64 (SpaghettiKart) - Default",
+	}, "default.sav", payload)
+
+	save := mustObject(t, body["save"], "save")
+	saveID := mustString(t, save["id"], "save.id")
+	if saveID == "" {
+		t.Fatalf("expected manifest default save upload to succeed: %s", prettyJSON(body))
+	}
+
+	list := h.request(http.MethodGet, "/saves?systemSlug=ports&limit=10", nil)
+	assertStatus(t, list, http.StatusOK)
+	listBody := decodeJSONMap(t, list.Body)
+	items := mustArray(t, listBody["saves"], "saves")
+	found := false
+	for _, raw := range items {
+		item := mustObject(t, raw, "save")
+		if mustString(t, item["id"], "save.id") == saveID {
+			found = true
+			break
+		}
+	}
+	if !found {
+		t.Fatalf("manifest default save was accepted but missing from ports list: %s", prettyJSON(listBody))
+	}
+
+	latest := h.request(http.MethodGet, "/save/latest?romSha1="+url.QueryEscape("port:spaghettikart")+"&slotName=default", nil)
+	assertStatus(t, latest, http.StatusOK)
+	latestBody := decodeJSONMap(t, latest.Body)
+	if mustString(t, latestBody["id"], "latest.id") != saveID {
+		t.Fatalf("latest did not resolve manifest default save: %s", prettyJSON(latestBody))
+	}
+}
diff --git a/backend/cmd/server/save_handlers.go b/backend/cmd/server/save_handlers.go
@@ -703,6 +703,7 @@ func (a *app) handleListSaves(w http.ResponseWriter, r *http.Request) {
 	romSHA1 := strings.TrimSpace(r.URL.Query().Get("romSha1"))
 	romMD5 := strings.TrimSpace(r.URL.Query().Get("romMd5"))
 	systemID := parseIntOrDefault(r.URL.Query().Get("systemId"), 0)
+	systemSlug := canonicalOptionalSegment(firstNonEmpty(r.URL.Query().Get("systemSlug"), r.URL.Query().Get("system")))
 
 	records := a.snapshotSaveRecords()
 	filteredRecords := make([]saveRecord, 0, len(records))
@@ -718,6 +719,9 @@ func (a *app) handleListSaves(w http.ResponseWriter, r *http.Request) {
 				continue
 			}
 		}
+		if systemSlug != "" && canonicalOptionalSegment(saveRecordSystemSlug(record)) != systemSlug {
+			continue
+		}
 		filteredRecords = append(filteredRecords, record)
 	}
 
@@ -782,8 +786,10 @@ func (a *app) handleListSaves(w http.ResponseWriter, r *http.Request) {
 		summary.LatestVersion = summary.Version
 		filtered = append(filtered, summary)
 	}
-	if romMD5 == "" {
+	if romMD5 == "" && (systemSlug == "" || systemSlug == "psx" || systemSlug == "ps2") {
 		filtered = append(filtered, a.playStationLogicalListSummaries(systemID)...)
+	}
+	if romMD5 == "" && (systemSlug == "" || systemSlug == "n64") {
 		filtered = append(filtered, a.n64ControllerPakListSummaries(systemID, romSHA1)...)
 	}
 	sort.Slice(filtered, func(i, j int) bool {
diff --git a/backend/cmd/server/system_detection.go b/backend/cmd/server/system_detection.go
@@ -249,8 +249,10 @@ func detectSaveSystem(input saveSystemDetectionInput) saveSystemDetectionResult
 	displayTitle := strings.TrimSpace(input.DisplayTitle)
 	ext := strings.TrimPrefix(strings.ToLower(filepath.Ext(filename)), ".")
 	payload := input.Payload
+	declaredSlug := canonicalOptionalSegment(input.DeclaredSystemSlug)
+	trustedNativePort := declaredSlug == nativePortSystemSlug && (input.TrustedHelperSystem || input.TrustedStoredSystem)
 
-	if noisy, reason := isLikelyNoiseFilename(filename); noisy {
+	if noisy, reason := isLikelyNoiseFilename(filename); noisy && !trustedNativePort {
 		return saveSystemDetectionResult{
 			Slug:       "unknown-system",
 			System:     nil,
diff --git a/frontend/src/app/layouts/AppLayout.tsx b/frontend/src/app/layouts/AppLayout.tsx
@@ -1,12 +1,13 @@
 import { useEffect, useMemo, useState } from "react";
 import { Link, NavLink, Outlet, useNavigate } from "react-router-dom";
-import { AlertTriangle, Database, FileWarning, KeyRound, ListChecks, LogOut, MonitorSmartphone, ScrollText, Settings, Wand2 } from "lucide-react";
+import { AlertTriangle, Database, FileWarning, Gamepad2, KeyRound, ListChecks, LogOut, MonitorSmartphone, ScrollText, Settings, Wand2 } from "lucide-react";
 import { clearFrontendAuthSession, isFrontendAuthRequired } from "../../services/authSession";
 import { enableAutoAppPasswordEnrollment, getAutoAppPasswordEnrollmentStatus, getRuntimeConfig } from "../../services/retrosaveApi";
 import type { RuntimeConfig } from "../../services/types";
 
 const appNav: Array<{ label: string; to: string; icon: typeof Database }> = [
   { label: "My Saves", to: "/app/my-games", icon: Database },
+  { label: "Ports", to: "/app/ports", icon: Gamepad2 },
   { label: "Cheats", to: "/app/cheats", icon: Wand2 },
   { label: "Validation", to: "/app/validation", icon: ListChecks },
   { label: "Logs", to: "/app/logs", icon: ScrollText },
@@ -97,12 +98,16 @@ function RuntimeWarning({ runtime }: { runtime: RuntimeConfig | null }): JSX.Ele
   if (!warning) {
     return null;
   }
+  const displayWarning = warning.replace(
+    "Keep this instance on a trusted LAN or protect it behind your own reverse proxy.",
+    "Trusted LAN or reverse proxy required."
+  );
   return (
     <section className="runtime-warning" role="status" aria-live="polite">
       <AlertTriangle aria-hidden="true" />
       <div>
         <strong>LAN-only mode</strong>
-        <span>{warning}</span>
+        <span title={warning}>{displayWarning}</span>
       </div>
     </section>
   );
diff --git a/frontend/src/app/layouts/__tests__/AppLayout.test.tsx b/frontend/src/app/layouts/__tests__/AppLayout.test.tsx
@@ -65,6 +65,7 @@ describe("AppLayout", () => {
     );
 
     expect(screen.getByRole("link", { name: "My Saves" })).toBeInTheDocument();
+    expect(screen.getByRole("link", { name: "Ports" })).toBeInTheDocument();
     expect(screen.getByRole("link", { name: "Cheats" })).toBeInTheDocument();
     expect(screen.queryByRole("link", { name: "My Games" })).not.toBeInTheDocument();
     expect(screen.queryByRole("link", { name: "Getting Started" })).not.toBeInTheDocument();
diff --git a/frontend/src/app/routes.tsx b/frontend/src/app/routes.tsx
@@ -88,6 +88,7 @@ export const appRouter = createBrowserRouter([
     children: [
       { index: true, element: <Navigate to="/app/my-games" replace /> },
       { path: "my-games", element: <MyGamesPage /> },
+      { path: "ports", element: <MyGamesPage title="Ports" systemSlugFilter="ports" emptyLabel="No native port saves found." /> },
       { path: "cheats", element: <CheatsPage /> },
       { path: "validation", element: <ValidationPage /> },
       { path: "logs", element: <LogsPage /> },
diff --git a/frontend/src/pages/app/MyGamesPage.tsx b/frontend/src/pages/app/MyGamesPage.tsx
@@ -37,7 +37,13 @@ const DEFAULT_SORT: { key: SaveSortKey; direction: SaveSortDirection } = {
 
 const SAVE_PAGE_SIZE = 100;
 
-export function MyGamesPage(): JSX.Element {
+type MyGamesPageProps = {
+  title?: string;
+  systemSlugFilter?: string;
+  emptyLabel?: string;
+};
+
+export function MyGamesPage({ title = "My Saves", systemSlugFilter, emptyLabel = "No saves found." }: MyGamesPageProps = {}): JSX.Element {
   const [deleteError, setDeleteError] = useState<string | null>(null);
   const [deletingKeys, setDeletingKeys] = useState<string[]>([]);
   const [pendingDeleteRow, setPendingDeleteRow] = useState<SaveRow | null>(null);
@@ -71,9 +77,9 @@ export function MyGamesPage(): JSX.Element {
   const [cheatPendingUpdates, setCheatPendingUpdates] = useState<Record<string, unknown>>({});
   const [saveLimit, setSaveLimit] = useState(SAVE_PAGE_SIZE);
 
-  const loader = useCallback(async () => listSaves({ limit: saveLimit, offset: 0 }), [saveLimit]);
+  const loader = useCallback(async () => listSaves({ limit: saveLimit, offset: 0, systemSlug: systemSlugFilter }), [saveLimit, systemSlugFilter]);
 
-  const { loading, error, data, reload } = useAsyncData(loader, [saveLimit]);
+  const { loading, error, data, reload } = useAsyncData(loader, [saveLimit, systemSlugFilter]);
 
   const loadedSaves = data?.saves ?? [];
   const totalAvailableSaves = data?.total ?? loadedSaves.length;
@@ -474,7 +480,7 @@ export function MyGamesPage(): JSX.Element {
   }
 
   if (loading && loadedSaves.length === 0) {
-    return <LoadingState label="Loading My Saves..." />;
+    return <LoadingState label={`Loading ${title}...`} />;
   }
 
   if (error) {
@@ -485,7 +491,7 @@ export function MyGamesPage(): JSX.Element {
     <section className="treegrid-panel fade-in-up">
       <header className="treegrid-panel__header">
         <div>
-          <h1>My Saves</h1>
+          <h1>{title}</h1>
           <p>{summaryText}</p>
         </div>
         <button className="treegrid-header-action" type="button" onClick={openUploadModal}>
@@ -495,7 +501,7 @@ export function MyGamesPage(): JSX.Element {
 
       {deleteError ? <p className="error-state">{deleteError}</p> : null}
       {loadingMore ? <p className="treegrid-panel__status">Refreshing save library...</p> : null}
-      {rows.length === 0 ? <p className="treegrid-panel__empty">No saves found.</p> : null}
+      {rows.length === 0 ? <p className="treegrid-panel__empty">{emptyLabel}</p> : null}
 
       {rows.length > 0 ? (
         <MyGamesLibraryTable
diff --git a/frontend/src/pages/app/__tests__/MyGamesPage.treegrid.test.tsx b/frontend/src/pages/app/__tests__/MyGamesPage.treegrid.test.tsx
@@ -1,4 +1,5 @@
 import { fireEvent, render, screen, waitFor } from "@testing-library/react";
+import type { ComponentProps } from "react";
 import { MemoryRouter } from "react-router-dom";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import { MyGamesPage } from "../MyGamesPage";
@@ -59,10 +60,10 @@ function makeSave(overrides: Partial<SaveSummary> & { id: string; title: string;
   };
 }
 
-function renderPage(): ReturnType<typeof render> {
+function renderPage(props?: ComponentProps<typeof MyGamesPage>): ReturnType<typeof render> {
   return render(
     <MemoryRouter>
-      <MyGamesPage />
+      <MyGamesPage {...props} />
     </MemoryRouter>
   );
 }
@@ -251,6 +252,13 @@ describe("MyGamesPage TreeGrid", () => {
     expect(await screen.findByText("Chrono Trigger")).toBeInTheDocument();
   });
 
+  it("can render the dedicated Ports library route with backend-side filtering", async () => {
+    renderPage({ title: "Ports", systemSlugFilter: "ports", emptyLabel: "No native port saves found." });
+
+    expect(await screen.findByRole("heading", { name: "Ports" })).toBeInTheDocument();
+    expect(retrosaveApi.listSaves).toHaveBeenCalledWith({ limit: 100, offset: 0, systemSlug: "ports" });
+  });
+
   it("sorts rows inside a console group and opens the download profile popup with the preserved PlayStation key", async () => {
     const view = renderPage();
 
diff --git a/frontend/src/services/retrosaveApi.ts b/frontend/src/services/retrosaveApi.ts
@@ -81,10 +81,17 @@ export function getRuntimeConfig(): Promise<{ success: boolean; runtime: Runtime
   return apiFetchJSON<{ success: boolean; runtime: RuntimeConfig }>("/api/runtime-config");
 }
 
-export async function listSaves(params: { limit?: number; offset?: number } = {}): Promise<SaveListResponse> {
+export async function listSaves(params: { limit?: number; offset?: number; systemSlug?: string } = {}): Promise<SaveListResponse> {
   const limit = params.limit && params.limit > 0 ? params.limit : 100;
   const offset = params.offset && params.offset > 0 ? params.offset : 0;
-  return apiFetchJSON<SaveListResponse>(`/saves?limit=${encodeURIComponent(String(limit))}&offset=${encodeURIComponent(String(offset))}`);
+  const query = new URLSearchParams({
+    limit: String(limit),
+    offset: String(offset)
+  });
+  if (params.systemSlug?.trim()) {
+    query.set("systemSlug", params.systemSlug.trim());
+  }
+  return apiFetchJSON<SaveListResponse>(`/saves?${query.toString()}`);
 }
 
 export function uploadSaveFile(params: {
diff --git a/frontend/src/styles/layers/foundation.css b/frontend/src/styles/layers/foundation.css
@@ -24,9 +24,11 @@ html,
 body,
 #root {
   min-height: 100%;
+  background: #13151b;
 }
 
 body {
+  min-height: 100vh;
   margin: 0;
   font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif;
   -webkit-font-smoothing: antialiased;
@@ -56,6 +58,7 @@ code {
   display: grid;
   grid-template-columns: 248px minmax(0, 1fr);
   min-height: 100vh;
+  min-height: 100dvh;
 }
 
 .app-sidebar {
diff --git a/frontend/src/styles/layers/treegrid-dialogs.css b/frontend/src/styles/layers/treegrid-dialogs.css
@@ -1064,6 +1064,10 @@
   margin-top: 1px;
 }
 
+.runtime-warning > div {
+  min-width: 0;
+}
+
 .runtime-warning strong,
 .runtime-warning span {
   display: block;
@@ -1081,6 +1085,7 @@
   color: #e9d2a3;
   font-size: 12px;
   line-height: 1.35;
+  overflow-wrap: anywhere;
 }
 
 .treegrid-panel__status {

Original file line number	Diff line number	Diff line change
`@@ -703,6 +703,7 @@ func (a app) handleListSaves(w http.ResponseWriter, r http.Request) {`
`703`	`703`	`romSHA1 := strings.TrimSpace(r.URL.Query().Get("romSha1"))`
`704`	`704`	`romMD5 := strings.TrimSpace(r.URL.Query().Get("romMd5"))`
`705`	`705`	`systemID := parseIntOrDefault(r.URL.Query().Get("systemId"), 0)`
	`706`	`+ systemSlug := canonicalOptionalSegment(firstNonEmpty(r.URL.Query().Get("systemSlug"), r.URL.Query().Get("system")))`
`706`	`707`
`707`	`708`	`records := a.snapshotSaveRecords()`
`708`	`709`	`filteredRecords := make([]saveRecord, 0, len(records))`
`@@ -718,6 +719,9 @@ func (a app) handleListSaves(w http.ResponseWriter, r http.Request) {`
`718`	`719`	`continue`
`719`	`720`	`}`
`720`	`721`	`}`
	`722`	`+ if systemSlug != "" && canonicalOptionalSegment(saveRecordSystemSlug(record)) != systemSlug {`
	`723`	`+ continue`
	`724`	`+ }`
`721`	`725`	`filteredRecords = append(filteredRecords, record)`
`722`	`726`	`}`
`723`	`727`
`@@ -782,8 +786,10 @@ func (a app) handleListSaves(w http.ResponseWriter, r http.Request) {`
`782`	`786`	`summary.LatestVersion = summary.Version`
`783`	`787`	`filtered = append(filtered, summary)`
`784`	`788`	`}`
`785`		`- if romMD5 == "" {`
	`789`	`+ if romMD5 == "" && (systemSlug == "" \|\| systemSlug == "psx" \|\| systemSlug == "ps2") {`
`786`	`790`	`filtered = append(filtered, a.playStationLogicalListSummaries(systemID)...)`
	`791`	`+ }`
	`792`	`+ if romMD5 == "" && (systemSlug == "" \|\| systemSlug == "n64") {`
`787`	`793`	`filtered = append(filtered, a.n64ControllerPakListSummaries(systemID, romSHA1)...)`
`788`	`794`	`}`
`789`	`795`	`sort.Slice(filtered, func(i, j int) bool {`