Add upload validation and sync profile tools

Author: joeblack2k

backend/cmd/server/agent_api_handlers.go

@@ -40,6 +40,7 @@ func mountAgentRoutes(r chi.Router, app *app) {
 	r.Get("/save/latest", app.handleSaveLatest)
 	r.Get("/saves", app.handleAgentSavesList)
 	r.Post("/saves", app.handleSaves)
+	r.Post("/saves/preview", app.handleSavesPreview)
 	r.Delete("/saves", app.handleDeleteManySaves)
 	r.Post("/saves/rescan", app.handleAgentSaveRescan)
 	r.Get("/saves/download-many", app.handleDownloadManySaves)
@@ -65,6 +66,9 @@ func mountAgentRoutes(r chi.Router, app *app) {
 	r.Get("/helpers/auto-enroll", app.handleAuthAppPasswordsAutoStatus)
 	r.Post("/helpers/auto-enroll", app.handleAuthAppPasswordsAutoEnable)
 
+	r.Get("/validation", app.handleValidationStatus)
+	r.Post("/validation/rescan", app.handleValidationRescan)
+
 	r.Get("/modules", app.handleModulesList)
 	r.Post("/modules/sync", app.handleModulesSync)
 	r.Post("/modules/upload", app.handleModulesUpload)
@@ -112,10 +116,13 @@ func (a *app) handleAgentAPIIndex(w http.ResponseWriter, r *http.Request) {
 			"helperHeartbeat":    basePath + "/helpers/heartbeat",
 			"logs":               basePath + "/logs",
 			"saves":              basePath + "/saves",
+			"savesPreview":       basePath + "/saves/preview",
 			"saveLatest":         basePath + "/save/latest",
 			"roms":               basePath + "/roms",
 			"romLookup":          basePath + "/roms/lookup",
 			"conflicts":          basePath + "/conflicts",
+			"validation":         basePath + "/validation",
+			"validationRescan":   basePath + "/validation/rescan",
 			"autoEnroll":         basePath + "/helpers/auto-enroll",
 			"modules":            basePath + "/modules",
 			"modulesSync":        basePath + "/modules/sync",

backend/cmd/server/save_handlers.go

@@ -268,7 +268,7 @@ func (a *app) handleSaves(w http.ResponseWriter, r *http.Request) {
 			SlotName:            strings.TrimSpace(formValue("slotName")),
 			SystemSlug:          declaredSystem,
 			GameSlug:            canonicalSegment(gameInfo.Name, "unknown-game"),
-			TrustedHelperSystem: helperCtx.IsHelper && strings.TrimSpace(formValue("system")) != "",
+			TrustedHelperSystem: strings.TrimSpace(formValue("system")) != "",
 		}
 		if helperCtx.IsHelper && isProjectionCapableSystem(declaredSystem) && declaredSystem != "psx" && declaredSystem != "ps2" {
 			if runtimeProfile == "" {
@@ -277,6 +277,7 @@ func (a *app) handleSaves(w http.ResponseWriter, r *http.Request) {
 			}
 			input, err = normalizeProjectionUpload(input, runtimeProfile)
 			if err != nil {
+				a.quarantineRejectedUpload(filename, "", payload, rejectedPreviewItem(filename, "", payload, declaredSystem, input.Format, runtimeProfile, err.Error()), deviceName)
 				writeJSON(w, http.StatusUnprocessableEntity, apiError{Error: "Unprocessable Entity", Message: err.Error(), StatusCode: http.StatusUnprocessableEntity})
 				return
 			}
@@ -291,6 +292,7 @@ func (a *app) handleSaves(w http.ResponseWriter, r *http.Request) {
 			if rejectReason != "" {
 				logMessage = logMessage + ": " + rejectReason
 			}
+			a.quarantineRejectedUpload(filename, "", payload, previewItemFromNormalized(filename, "", payload, runtimeProfile, preview), deviceName)
 			a.appendSyncLog(syncLogInput{
 				DeviceName:   deviceName,
 				Action:       "upload",
@@ -486,6 +488,10 @@ func (a *app) handleSaves(w http.ResponseWriter, r *http.Request) {
 				SystemSlug:   preview.Input.SystemSlug,
 			})
 			if errors.Is(err, errUnsupportedSaveFormat) {
+				item := previewItemFromNormalized(filename, "", payload, runtimeProfile, preview)
+				item.Accepted = false
+				item.Reason = firstNonEmpty(unsupportedSaveRejectReason(err), err.Error())
+				a.quarantineRejectedUpload(filename, "", payload, item, deviceName)
 				writeJSON(w, http.StatusUnprocessableEntity, apiError{
 					Error:      "Unprocessable Entity",
 					Message:    errUnsupportedSaveFormat.Error(),

backend/cmd/server/save_upload_expansion.go

@@ -147,7 +147,7 @@ func (a *app) handleExpandedMultipartSaveUploads(w http.ResponseWriter, helperCt
 			SlotName:            firstNonEmpty(strings.TrimSpace(formValue("slotName")), upload.SourcePath),
 			SystemSlug:          upload.SystemSlug,
 			GameSlug:            canonicalSegment(upload.Game.Name, "unknown-game"),
-			TrustedHelperSystem: helperCtx.IsHelper && strings.TrimSpace(formValue("system")) != "",
+			TrustedHelperSystem: strings.TrimSpace(formValue("system")) != "",
 		}
 		preview := a.normalizeSaveInputDetailed(input)
 		if preview.Rejected || !isSupportedSystemSlug(preview.Input.SystemSlug) {
@@ -156,6 +156,7 @@ func (a *app) handleExpandedMultipartSaveUploads(w http.ResponseWriter, helperCt
 			if rejectReason != "" {
 				logMessage += ": " + rejectReason
 			}
+			a.quarantineRejectedUpload(upload.Filename, upload.SourcePath, upload.Payload, previewItemFromNormalized(upload.Filename, upload.SourcePath, upload.Payload, "", preview), deviceName)
 			a.appendSyncLog(syncLogInput{DeviceName: deviceName, Action: "upload", Game: syncLogGameLabelFromFilename(upload.Filename), ErrorMessage: logMessage, SystemSlug: preview.Input.SystemSlug})
 			errorCount++
 			results = append(results, map[string]any{"filename": upload.Filename, "sourcePath": upload.SourcePath, "success": false, "error": errUnsupportedSaveFormat.Error(), "reason": rejectReason})
@@ -195,6 +196,10 @@ func (a *app) handleExpandedMultipartSaveUploads(w http.ResponseWriter, helperCt
 				if reason := unsupportedSaveRejectReason(err); reason != "" {
 					result["reason"] = reason
 				}
+				item := previewItemFromNormalized(upload.Filename, upload.SourcePath, upload.Payload, "", preview)
+				item.Accepted = false
+				item.Reason = firstNonEmpty(unsupportedSaveRejectReason(err), err.Error())
+				a.quarantineRejectedUpload(upload.Filename, upload.SourcePath, upload.Payload, item, deviceName)
 			}
 			results = append(results, result)
 			continue