Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions backend/cmd/server/save_format_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package main

import "testing"

func TestSaveRecordFormat(t *testing.T) {
cases := []struct {
name string
payloadFile string
want string
}{
{"gb battery save", "payload.srm", "srm"},
{"gb rtc save", "payload.rtc", "rtc"},
{"uppercase extension is normalized", "payload.SRM", "srm"},
{"no extension", "payload", ""},
{"empty payload file", "", ""},
{"multi-dot keeps final ext", "payload.tar.gz", "gz"},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
got := saveRecordFormat(saveRecord{PayloadFile: tc.payloadFile})
if got != tc.want {
t.Fatalf("saveRecordFormat(%q) = %q, want %q", tc.payloadFile, got, tc.want)
}
})
}
}
13 changes: 13 additions & 0 deletions backend/cmd/server/save_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"io"
"net/http"
"os"
"path/filepath"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -107,6 +108,15 @@ func latestReadableSaveRecordByTrackContext(records []saveRecord, filename, syst
return latestSaveRecordForKey(records, trackKey, canonicalDuplicateTrackKeyForRecord)
}

// saveRecordFormat returns the bare lowercase payload extension (e.g. "rtc",
// "srm"), or "" when unknown. Helpers use it to distinguish co-slotted save
// components that share a slotName — notably Game Boy battery saves (.srm) and
// RTC saves (.rtc) — so a smaller, newer companion file is not mistaken for a
// newer revision of the other and allowed to clobber it as "latest".
func saveRecordFormat(rec saveRecord) string {
return strings.TrimPrefix(strings.ToLower(filepath.Ext(rec.PayloadFile)), ".")
}

func (a *app) handleSaveLatest(w http.ResponseWriter, r *http.Request) {
_ = requestPrincipal(r)
helperCtx, ok := a.authorizeHelperSyncRequest(w, r, nil)
Expand Down Expand Up @@ -139,6 +149,7 @@ func (a *app) handleSaveLatest(w http.ResponseWriter, r *http.Request) {
"sha256": latest.Summary.SHA256,
"version": latest.Summary.Version,
"id": latest.Summary.ID,
"format": saveRecordFormat(latest),
})
return
}
Expand All @@ -154,6 +165,7 @@ func (a *app) handleSaveLatest(w http.ResponseWriter, r *http.Request) {
"sha256": latest.Summary.SHA256,
"version": latest.Summary.Version,
"id": latest.Summary.ID,
"format": saveRecordFormat(latest),
})
return
}
Expand Down Expand Up @@ -217,6 +229,7 @@ func (a *app) handleSaveLatest(w http.ResponseWriter, r *http.Request) {
"sha256": shaValue,
"version": latest.Summary.Version,
"id": latest.Summary.ID,
"format": saveRecordFormat(latest),
})
return
}
Expand Down
Loading