Clusters password as environment variables

[joacatito]

Please add the possibility to set each cluster password as an environment variable.

This would be helpful for k8s/Openshift deployments.

We can mount the passwords as secrets and use them on the mounted connection config files.

[joacatito]

Something like this:

{
"connections": [
{
"label": "MY-CLUSTER_1",
"clusters": [
{
"host": "MYCLUSTER_LEADER_1_0:6379",
"port": 6379
},
{
"host": "MYCLUSTER_LEADER_1_1:6379",
"port": 6379
},
{
"host": "MYCLUSTER_LEADER_1_2:6379",
"port": 6379
}
],
"password": "${MY_CLUSTER_1_PASSWORD}",
"dbIndex": 0
},
{
"label": "MY-CLUSTER_2",
"clusters": [
{
"host": "MYCLUSTER_LEADER_2_0:6379",
"port": 6379
},
{
"host": "MYCLUSTER_LEADER_2_1:6379",
"port": 6379
},
{
"host": "MYCLUSTER_LEADER_2_2:6379",
"port": 6379
}
],
"password": "${MY_CLUSTER_2_PASSWORD}",
"dbIndex": 0
}
]
}

[sseide]

Maybe the env var REPLACE_CONFIG_ENV might help here?

define your config json file as you like but write the password inside the json as $MY_CLUSTER_2_PASSWORD and so on (no curly brackets!). So it looks like your config above.

Now set REPLACE_CONFIG_ENV=MY_CLUSTER_2_PASSWORD. This env var supports a comma separated list of environment variable names.
Right before the start of Redis commander a search-and-replace is done inside all json config files for the names listed inside REPLACE_CONFIG_ENV and the occurances are replaced with the content of the environmant variable with the same name.

Now you can mount the MY_CLUSTER_2_PASSWORD as k8s secret.

check entrypoint.sh starting at line 341:

redis-commander/docker/entrypoint.sh

Lines 341 to 362 in 9bfb956

	if [ -n "$REPLACE_CONFIG_ENV" ]; then
	# special case for more complex docker setup with multiple connections
	# to unix sockets, sentinels and normal redis server not configurable
	# via REDIS_HOSTS...
	# search all config files (except custom-environment-variables.json) and do in place
	# replacement of a string to the value of the env var, e.g.
	# set $REPLACE_CONFIG_ENV=REDIS_PASS_1 and env REDIS_PASS_1=mypass
	# now search config files for string "REDIS_PASS_1" and write there "mypass" instead
	env_vars_replace="$(echo "${REPLACE_CONFIG_ENV}" | sed "s/,/ /g")"
	echo "Going to replace this env vars inside config files: $env_vars_replace"
	for env_var in ${env_vars_replace}; do
	for json_conf in config/*.json; do
	if [ "$json_conf" != "config/custom-environment-variables.json" ]; then
	# need to replace &\/ from content of env_var var as they are special chars in sed
	sed -i 's/"'"$env_var"'"/"'"$(printenv "$env_var" | sed 's/\\/\\\\/g; s/&/\\&/g; s#/#\\/#g;')"'"/g' "$json_conf"
	fi
	done
	done
	fi
	# all other env vars are evaluated by node-config module ...