Change .location, NewLocation, and Location to lazily compute location information#5530
Merged
Conversation
johannescoetzee
force-pushed
the
markus/lazyloc
branch
4 times, most recently
from
11ae016 to
46dcdf5
Compare
johannescoetzee
approved these changes
Jun 25, 2025
Contributor
johannescoetzee
left a comment
johannescoetzee
left a comment
There was a problem hiding this comment.
Approving on behalf of @ml86. From a Slack message from him:
Consider the joern PR approved. Since i opened it, you need to approve it
johannescoetzee
force-pushed
the
markus/lazyloc
branch
from
e33eed5 to
7fa899f
Compare
mpollmeier
added a commit
that referenced
this pull request
Jul 30, 2025
prior to this change:
```
List((1,2,3)).toJson
// [{"head":1,"next":{"head":2,"next":{"head":3,"next":{}}}}]
```
now:
```
List((1,2,3)).toJson
// [1,2,3]
```
It's a regression that was introduced in #5530
I have no idea why Michael Flanders made this change.
This is also adding a test so we catch it early next time round.
mpollmeier
added a commit
that referenced
this pull request
Jul 30, 2025
* fix json serializer: define only for nodes, not for all Products
prior to this change:
```
List((1,2,3)).toJson
// [{"head":1,"next":{"head":2,"next":{"head":3,"next":{}}}}]
```
now:
```
List((1,2,3)).toJson
// [1,2,3]
```
It's a regression that was introduced in #5530
I have no idea why Michael Flanders made this change.
This is also adding a test so we catch it early next time round.
* fixup json serializer and tests
We don't want to serialize _all_ products, that's the main point of this
PR. But since Location is not a node and we still want to serialize it,
and it makes sense to have the product accessors, I added a marker trait
that let's us specifically format types using the product accessors...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a copy of #5482 which
got closed because Michael Flanders deleted the repository from which
he made the pull request.