Log task ID when scheduling and executing tasks in RuntimeScheduler (facebook#52191)

Summary:
Pull Request resolved: facebook#52191

Changelog: [internal]

Some time ago we added logging for the timer ID in Systrace/Perfetto so we could see where timers were scheduled vs. executed.

This diff adds support for the same functionality for tasks in the runtime scheduler.

Reviewed By: javache

Differential Revision: D77039038

fbshipit-source-id: 792d2fe29b44fb209f9129f46f9d661dad7ebdff

Author: rubennorte

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp

@@ -50,13 +50,6 @@ void RuntimeScheduler_Modern::scheduleWork(RawCallback&& callback) noexcept {
 std::shared_ptr<Task> RuntimeScheduler_Modern::scheduleTask(
     SchedulerPriority priority,
     jsi::Function&& callback) noexcept {
-  TraceSection s(
-      "RuntimeScheduler::scheduleTask",
-      "priority",
-      serialize(priority),
-      "callbackType",
-      "jsi::Function");
-
   auto expirationTime = now_() + timeoutForSchedulerPriority(priority);
   auto task =
       std::make_shared<Task>(priority, std::move(callback), expirationTime);
@@ -69,13 +62,6 @@ std::shared_ptr<Task> RuntimeScheduler_Modern::scheduleTask(
 std::shared_ptr<Task> RuntimeScheduler_Modern::scheduleTask(
     SchedulerPriority priority,
     RawCallback&& callback) noexcept {
-  TraceSection s(
-      "RuntimeScheduler::scheduleTask",
-      "priority",
-      serialize(priority),
-      "callbackType",
-      "RawCallback");
-
   auto expirationTime = now_() + timeoutForSchedulerPriority(priority);
   auto task =
       std::make_shared<Task>(priority, std::move(callback), expirationTime);
@@ -233,6 +219,13 @@ void RuntimeScheduler_Modern::setIntersectionObserverDelegate(
 #pragma mark - Private
 
 void RuntimeScheduler_Modern::scheduleTask(std::shared_ptr<Task> task) {
+  TraceSection s(
+      "RuntimeScheduler::scheduleTask",
+      "priority",
+      serialize(task->priority),
+      "id",
+      task->id);
+
   bool shouldScheduleEventLoop = false;
 
   {
@@ -384,6 +377,8 @@ void RuntimeScheduler_Modern::executeTask(
     bool didUserCallbackTimeout) const {
   TraceSection s(
       "RuntimeScheduler::executeTask",
+      "id",
+      task.id,
       "priority",
       serialize(task.priority),
       "didUserCallbackTimeout",

packages/react-native/ReactCommon/react/renderer/runtimescheduler/Task.cpp

@@ -5,25 +5,37 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#include "RuntimeScheduler.h"
+#include "Task.h"
+#include <atomic>
 
 namespace facebook::react {
 
+namespace {
+
+inline uint64_t getNextId() noexcept {
+  static std::atomic<uint64_t> nextId = 1;
+  return nextId++;
+}
+
+} // namespace
+
 Task::Task(
     SchedulerPriority priority,
     jsi::Function&& callback,
     HighResTimeStamp expirationTime)
     : priority(priority),
       callback(std::move(callback)),
-      expirationTime(expirationTime) {}
+      expirationTime(expirationTime),
+      id(getNextId()) {}
 
 Task::Task(
     SchedulerPriority priority,
     RawCallback&& callback,
     HighResTimeStamp expirationTime)
     : priority(priority),
       callback(std::move(callback)),
-      expirationTime(expirationTime) {}
+      expirationTime(expirationTime),
+      id(getNextId()) {}
 
 jsi::Value Task::execute(jsi::Runtime& runtime, bool didUserCallbackTimeout) {
   auto result = jsi::Value::undefined();

packages/react-native/ReactCommon/react/renderer/runtimescheduler/Task.h

@@ -11,6 +11,7 @@
 #include <jsi/jsi.h>
 #include <react/timing/primitives.h>
 
+#include <cstdint>
 #include <optional>
 #include <variant>
 
@@ -41,6 +42,7 @@ struct Task final : public jsi::NativeState {
   SchedulerPriority priority;
   std::optional<std::variant<jsi::Function, RawCallback>> callback;
   HighResTimeStamp expirationTime;
+  uint64_t id;
 
   jsi::Value execute(jsi::Runtime& runtime, bool didUserCallbackTimeout);
 };