Skip to content

Commit 55ea948

Browse files
joevilchesfacebook-github-bot
authored andcommitted
Clean up weird comment in ReactScrollView (facebook#54807)
Summary: Was reading this code and this comment seems unnecessary. Was added in 2016 0_0 Differential Revision: D88509989
1 parent d2b065f commit 55ea948

File tree

1 file changed

+1
-10
lines changed
  • packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll

1 file changed

+1
-10
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -780,8 +780,6 @@ public void fling(int velocityY) {
780780
if (mPagingEnabled) {
781781
flingAndSnap(correctedVelocityY);
782782
} else if (mScroller != null) {
783-
// FB SCROLLVIEW CHANGE
784-
785783
// We provide our own version of fling that uses a different call to the standard OverScroller
786784
// which takes into account the possibility of adding new content while the ScrollView is
787785
// animating. Because we give essentially no max Y for the fling, the fling will continue as
@@ -806,8 +804,6 @@ public void fling(int velocityY) {
806804
);
807805

808806
ViewCompat.postInvalidateOnAnimation(this);
809-
810-
// END FB SCROLLVIEW CHANGE
811807
} else {
812808
super.fling(correctedVelocityY);
813809
}
@@ -1266,11 +1262,8 @@ public void setEndFillColor(int color) {
12661262
@Override
12671263
protected void onOverScrolled(int scrollX, int scrollY, boolean clampedX, boolean clampedY) {
12681264
if (mScroller != null && mContentView != null) {
1269-
// FB SCROLLVIEW CHANGE
1270-
12711265
// This is part two of the reimplementation of fling to fix the bounce-back bug. See #fling()
1272-
// for
1273-
// more information.
1266+
// for more information.
12741267

12751268
if (!mScroller.isFinished() && mScroller.getCurrY() != mScroller.getFinalY()) {
12761269
int scrollRange = getMaxScrollY();
@@ -1279,8 +1272,6 @@ protected void onOverScrolled(int scrollX, int scrollY, boolean clampedX, boolea
12791272
scrollY = scrollRange;
12801273
}
12811274
}
1282-
1283-
// END FB SCROLLVIEW CHANGE
12841275
}
12851276

12861277
if (ReactNativeFeatureFlags.shouldTriggerResponderTransferOnScrollAndroid()

0 commit comments

Comments
 (0)