[BUG - Magisk Canary 27008] Customize.sh doesn't working as expected

[diabl0w]

There is no config.txt
target.txt not getting updated

[joeyoropesa-dev]

There is no config.txt
target.txt not getting updated

Hello @diabl0w
Could you tell me more about your bug.

I need these informations:

• Root manager:
• Root manager version:
• ROM:
• Device model and responses of these commands:

:/ $ su
:/ # cat /data/adb/tricky_store/tee_status 
:/ # uname -a

• Screenshot of the getkb response (Look at README.md to know how to execute getkb)

[diabl0w]

There is no config.txt
target.txt not getting updated

Hello @diabl0w Could you tell me more about your bug.

I need these informations:

• Root manager:
• Root manager version:
• ROM:
• Device model and responses of these commands:

:/ $ su
:/ # cat /data/adb/tricky_store/tee_status 
:/ # uname -a

• Screenshot of the getkb response (Look at README.md to know how to execute getkb)

RootManager: magisk canary 27008
Commands:

:/data/adb/tricky_store # uname -a
Linux localhost 5.4.233-qgki-27940246-abF926BXXS6GXBD #1 SMP PREEMPT Mon Mar 4 10:48:57 KST 2024 aarch64 Toybox
:/data/adb/tricky_store # ls -la
total 14
drwxr-xr-x  2 root root 3452 2024-09-26 04:27 .
drwx------ 11 root root 3452 2020-02-06 12:07 ..
-rw-r--r--  1 root root 7513 2024-09-26 04:22 keybox.xml
-rw-r--r--  1 root root  155 2024-09-26 04:24 target.txt
-rw-rw-rw-  1 root root   15 2024-09-26 04:39 tee_status
:/data/adb/tricky_store # cat tee_status
teeBroken=false

getkb isn't going to work as you don't have a "system/bin" folder in your module, you only have "bin"

[joeyoropesa-dev]

There is no config.txt
target.txt not getting updated

Hello @diabl0w Could you tell me more about your bug.

I need these informations:

• Root manager:
• Root manager version:
• ROM:
• Device model and responses of these commands:

:/ $ su
:/ # cat /data/adb/tricky_store/tee_status 
:/ # uname -a

• Screenshot of the getkb response (Look at README.md to know how to execute getkb)

RootManager: magisk canary 27008
Commands:

:/data/adb/tricky_store # uname -a
Linux localhost 5.4.233-qgki-27940246-abF926BXXS6GXBD #1 SMP PREEMPT Mon Mar 4 10:48:57 KST 2024 aarch64 Toybox
:/data/adb/tricky_store # ls -la
total 14
drwxr-xr-x  2 root root 3452 2024-09-26 04:27 .
drwx------ 11 root root 3452 2020-02-06 12:07 ..
-rw-r--r--  1 root root 7513 2024-09-26 04:22 keybox.xml
-rw-r--r--  1 root root  155 2024-09-26 04:24 target.txt
-rw-rw-rw-  1 root root   15 2024-09-26 04:39 tee_status
:/data/adb/tricky_store # cat tee_status
teeBroken=false

getkb isn't going to work as you don't have a "system/bin" folder in your module, you only have "bin"

That's correct, /system/bin must be untouched but it still needs to work (like it worked for other people) since I'm adapting executables (including the ones that needs to be used during boot) in root manager's PATH since some root detection can detect if I use overlay to put executables somewhere in /system

Could you do getkb and ls for "/data/adb/magisk" and "/debug_ramdisk"? If this command didn't worked for you but these directories are used by official magisk canary build as PATH it could be that executable is not compatible. In that case, if PATH dir is not a problem, I will modify executables and push changes.

No one else had this issue before with executables in official magisk so this issue must be new if PATH are correct

[diabl0w]

There is no config.txt
target.txt not getting updated

Hello @diabl0w Could you tell me more about your bug.
I need these informations:

• Root manager:
• Root manager version:
• ROM:
• Device model and responses of these commands:

:/ $ su
:/ # cat /data/adb/tricky_store/tee_status 
:/ # uname -a

• Screenshot of the getkb response (Look at README.md to know how to execute getkb)

RootManager: magisk canary 27008
Commands:

:/data/adb/tricky_store # uname -a
Linux localhost 5.4.233-qgki-27940246-abF926BXXS6GXBD #1 SMP PREEMPT Mon Mar 4 10:48:57 KST 2024 aarch64 Toybox
:/data/adb/tricky_store # ls -la
total 14
drwxr-xr-x  2 root root 3452 2024-09-26 04:27 .
drwx------ 11 root root 3452 2020-02-06 12:07 ..
-rw-r--r--  1 root root 7513 2024-09-26 04:22 keybox.xml
-rw-r--r--  1 root root  155 2024-09-26 04:24 target.txt
-rw-rw-rw-  1 root root   15 2024-09-26 04:39 tee_status
:/data/adb/tricky_store # cat tee_status
teeBroken=false

getkb isn't going to work as you don't have a "system/bin" folder in your module, you only have "bin"

That's correct, /system/bin must be untouched but it still needs to work (like it worked for other people) since I'm adapting executables (including the ones that needs to be used during boot) in root manager's PATH since some root detection can detect if I use overlay to put executables somewhere in /system

Could you do getkb and ls for "/data/adb/magisk" and "/debug_ramdisk"? If this command didn't worked for you but these directories are used by official magisk canary build as PATH it could be that executable is not compatible. In that case, if PATH dir is not a problem, I will modify executables and push changes.

No one else had this issue before with executables in official magisk so this issue must be new if PATH are correct

:/ # ls /data/adb/magisk/
addon.d.sh     chromeos  magisk32    magiskpolicy
boot_patch.sh  init-ld   magiskboot  stub.apk
busybox        magisk    magiskinit  util_functions.sh
:/ # ls /debug_ramdisk/
magisk    magiskinit    resetprop  su
magisk32  magiskpolicy  shamiko    supolicy
:/ # getkb
: getkb: inaccessible or not found

[joeyoropesa-dev]

There is no config.txt
target.txt not getting updated

Hello @diabl0w Could you tell me more about your bug.
I need these informations:

• Root manager:
• Root manager version:
• ROM:
• Device model and responses of these commands:

:/ $ su
:/ # cat /data/adb/tricky_store/tee_status 
:/ # uname -a

• Screenshot of the getkb response (Look at README.md to know how to execute getkb)

RootManager: magisk canary 27008
Commands:

:/data/adb/tricky_store # uname -a
Linux localhost 5.4.233-qgki-27940246-abF926BXXS6GXBD #1 SMP PREEMPT Mon Mar 4 10:48:57 KST 2024 aarch64 Toybox
:/data/adb/tricky_store # ls -la
total 14
drwxr-xr-x  2 root root 3452 2024-09-26 04:27 .
drwx------ 11 root root 3452 2020-02-06 12:07 ..
-rw-r--r--  1 root root 7513 2024-09-26 04:22 keybox.xml
-rw-r--r--  1 root root  155 2024-09-26 04:24 target.txt
-rw-rw-rw-  1 root root   15 2024-09-26 04:39 tee_status
:/data/adb/tricky_store # cat tee_status
teeBroken=false

getkb isn't going to work as you don't have a "system/bin" folder in your module, you only have "bin"

That's correct, /system/bin must be untouched but it still needs to work (like it worked for other people) since I'm adapting executables (including the ones that needs to be used during boot) in root manager's PATH since some root detection can detect if I use overlay to put executables somewhere in /system
Could you do getkb and ls for "/data/adb/magisk" and "/debug_ramdisk"? If this command didn't worked for you but these directories are used by official magisk canary build as PATH it could be that executable is not compatible. In that case, if PATH dir is not a problem, I will modify executables and push changes.
No one else had this issue before with executables in official magisk so this issue must be new if PATH are correct

:/ # ls /data/adb/magisk/
addon.d.sh     chromeos  magisk32    magiskpolicy
boot_patch.sh  init-ld   magiskboot  stub.apk
busybox        magisk    magiskinit  util_functions.sh
:/ # ls /debug_ramdisk/
magisk    magiskinit    resetprop  su
magisk32  magiskpolicy  shamiko    supolicy
:/ # getkb
: getkb: inaccessible or not found

It's strange that none of executables was installed in "/debug_ramdisk"

Could you check using "touch" command is /debug_ramdisk writtable in your case

[diabl0w]

It's strange that none of executables was installed in "/debug_ramdisk"

Could you check using "touch" command is /debug_ramdisk writtable in your case

:/debug_ramdisk # ls
magisk    magiskinit    resetprop  su
magisk32  magiskpolicy  shamiko    supolicy
:/debug_ramdisk # touch test
:/debug_ramdisk # ls
magisk    magiskinit    resetprop  su        test
magisk32  magiskpolicy  shamiko    supolicy

[joeyoropesa-dev]

It's strange that none of executables was installed in "/debug_ramdisk"
Could you check using "touch" command is /debug_ramdisk writtable in your case

:/debug_ramdisk # ls
magisk    magiskinit    resetprop  su
magisk32  magiskpolicy  shamiko    supolicy
:/debug_ramdisk # touch test
:/debug_ramdisk # ls
magisk    magiskinit    resetprop  su        test
magisk32  magiskpolicy  shamiko    supolicy

You could try to remove module, reboot device, re-download module from the same sources (since zip got updated for v1.0.8), re-install module, reboot and open terminal to check is "getkb" installed in "/debug_ramdisk" - if it's still not there, there could be issues with customize.sh that needs to complete executable installation to specific directories based on what root you're using.

[diabl0w]

I'm using official magisk canary but I'm guessing these release notes from the equivalent alpha version are related

[diabl0w]

It's strange that none of executables was installed in "/debug_ramdisk"
Could you check using "touch" command is /debug_ramdisk writtable in your case

:/debug_ramdisk # ls
magisk    magiskinit    resetprop  su
magisk32  magiskpolicy  shamiko    supolicy
:/debug_ramdisk # touch test
:/debug_ramdisk # ls
magisk    magiskinit    resetprop  su        test
magisk32  magiskpolicy  shamiko    supolicy

You could try to remove module, reboot device, re-download module from the same sources (since zip got updated for v1.0.8), re-install module, reboot and open terminal to check is "getkb" installed in "/debug_ramdisk" - if it's still not there, there could be issues with customize.sh that needs to complete executable installation to specific directories based on what root you're using.

I'm already using 1.0.8 and already tried reinstalling so it would only get us to the same spot we are now

[joeyoropesa-dev]

I'm using official magisk canary but I'm guessing these release notes from the equivalent alpha version are related

customize.sh doesn't applying any mounts (to avoid overlay detections). The only thing that is doing is during installation, it installs (copying and setting correct permissions) executables required for the module to run (from module bin folder to root manager's PATH folder - in magisk it's /debug_ramdisk)

So if complete removal of the module, re-downloading updated zip from v1.0.8 and re-installing and rebooting worked for you, that means that customize.sh is not triggered correctly during updates for some reason and I will quickly figure out why.

That will also help me to instruct others who maybe also updated module but it didn't worked for them to re-download module so that changes may be applied to them too.

If after all module executables are still not installed, that means that customise.sh is the issue and maybe in that case I will move to install.sh method

[diabl0w]

I'm using official magisk canary but I'm guessing these release notes from the equivalent alpha version are related

customize.sh doesn't applying any mounts (to avoid overlay detections). The only thing that is doing is during installation, it installs (copying and setting correct permissions) executables required for the module to run (from module bin folder to root manager's PATH folder - in magisk it's /debug_ramdisk)

So if complete removal of the module, re-downloading updated zip from v1.0.8 and re-installing and rebooting worked for you, that means that customize.sh is not triggered during updates for some reason and I will quickly figure out why.

That will also help me to instruct others who maybe also updated module but it didn't worked for them to re-download module so that changes may be applied to them too.

If after all of this executables are still not installed, that means that customise.sh is the issue and maybe in that case I will move to install.sh method

Okay well I can confirm it doesn't work when trying from fresh install

[joeyoropesa-dev]

@topjohnwu We have a problem with Magisk compatibility about this module. Are you willing to collaborate?