review: use strict validator at IPC call sites; minor cleanup

Migrate electron/ipc/register.ts's loose validateBranchName (only rejected
empty / leading "-") to the new shared validator from electron/mcp/validation,
so the strict git-check-ref-format rules actually run today instead of waiting
for later coordinator PRs. Drop the now-unused orphan exemption for
validation.ts in .dependency-cruiser.cjs. Default the field name in
validateBranchName to "branch" rather than the misleading "baseBranch".
Comment .parallel-code/ in .gitignore.

Author: johannesjo

.dependency-cruiser.cjs

@@ -51,7 +51,6 @@ module.exports = {
           '^electron/mcp/server\\.ts$',
           // New subsystem files have no importers until coordinator PRs land
           '^electron/mcp/atomic\\.ts$',
-          '^electron/mcp/validation\\.ts$',
           // Vite ambient env declarations
           '^src/vite-env\\.d\\.ts$',
         ],

.gitignore

@@ -4,6 +4,7 @@ dist-electron
 dist-remote
 release
 coverage
+# Runtime data dir written by the app (MCP coordinator state, etc.)
 .parallel-code/
 .worktrees
 .idea

electron/ipc/register.ts

@@ -77,6 +77,7 @@ import {
   assertOptionalString,
   assertOptionalBoolean,
 } from './validate.js';
+import { validateBranchName } from '../mcp/validation.js';
 import { warn as logWarn } from '../log.js';
 
 function errMessage(err: unknown): string {
@@ -103,12 +104,6 @@ function validateRelativePath(p: unknown, label: string): void {
   if (p.includes('..')) throw new Error(`${label} must not contain ".."`);
 }
 
-/** Reject branch names that could be misinterpreted as git flags. */
-function validateBranchName(name: unknown, label: string): void {
-  if (typeof name !== 'string' || !name) throw new Error(`${label} must be a non-empty string`);
-  if (name.startsWith('-')) throw new Error(`${label} must not start with "-"`);
-}
-
 /** Reject commit hashes that are not valid hex strings. */
 function validateCommitHash(hash: unknown, label: string): void {
   if (typeof hash !== 'string') throw new Error(`${label} must be a string`);

electron/mcp/validation.ts

@@ -1,7 +1,7 @@
 // Shared branch-name validator used by MCP, REST, and IPC paths.
 // Conservative subset of git check-ref-format rules — no process spawn.
 
-export function validateBranchName(value: unknown, field = 'baseBranch'): string {
+export function validateBranchName(value: unknown, field = 'branch'): string {
   if (typeof value !== 'string') throw new Error(`${field} must be a string`);
   if (!value.trim()) throw new Error(`${field} must be a non-empty string`);
   // git check-ref-format --branch rejects HEAD specifically; FETCH_HEAD etc. are accepted.