fix(remote): guard mobile input while disconnected, harden WS tests

Author: johannesjo

electron/remote/server-ws.test.ts

@@ -60,9 +60,11 @@ function connectAndAuth(token: string): Promise<WebSocket> {
 function waitForClose(ws: WebSocket): Promise<number> {
   return new Promise((resolve) => {
     // Drop connectAndAuth's rejecting close/error listeners — from here on
-    // a close is the expected outcome, not a failure.
+    // a close is the expected outcome, not a failure. Keep a no-op error
+    // listener: an 'error' with no listener throws on EventEmitters.
     ws.removeAllListeners('close');
     ws.removeAllListeners('error');
+    ws.on('error', () => {});
     ws.on('close', (code) => resolve(code));
   });
 }
@@ -108,6 +110,31 @@ describe('mobile token over WebSocket', () => {
   });
 });
 
+describe('unauthenticated WebSocket clients', () => {
+  function connectRaw(): Promise<WebSocket> {
+    return new Promise((resolve, reject) => {
+      const ws = new WebSocket(`ws://127.0.0.1:${port}/ws`);
+      ws.on('open', () => resolve(ws));
+      ws.on('error', reject);
+    });
+  }
+
+  it('closes 4001 when input is sent before auth, without reaching the PTY', async () => {
+    const ws = await connectRaw();
+    const closed = waitForClose(ws);
+    ws.send(JSON.stringify({ type: 'input', agentId: 'agent-1', data: 'hi' }));
+    expect(await closed).toBe(4001);
+    expect(pty.writeToAgent).not.toHaveBeenCalled();
+  });
+
+  it('closes 4001 on auth with an unknown token', async () => {
+    const ws = await connectRaw();
+    const closed = waitForClose(ws);
+    ws.send(JSON.stringify({ type: 'auth', token: 'not-a-real-token' }));
+    expect(await closed).toBe(4001);
+  });
+});
+
 describe('coordinator token over WebSocket', () => {
   it('forwards input to the agent PTY', async () => {
     const ws = await connectAndAuth(coordinatorToken);

electron/remote/server.ts

@@ -831,7 +831,8 @@ export function startRemoteServer(opts: {
       const msg = parseClientMessage(String(raw));
       if (!msg) return;
 
-      // Handle first-message auth. Only coordinator token grants WS access.
+      // Handle first-message auth. Coordinator and mobile tokens grant WS
+      // access; subtask tokens are denied.
       if (msg.type === 'auth') {
         const tokenType = classifyCandidate(msg.token);
         if (tokenType === 'coordinator' || tokenType === 'mobile') {

src/remote/AgentDetail.tsx

@@ -180,6 +180,9 @@ export function AgentDetail(props: AgentDetailProps) {
   function handleSend() {
     const text = inputText();
     if (!text) return;
+    // Keep the typed text while disconnected — send() silently drops
+    // messages on a non-open socket, so clearing here would lose input.
+    if (status() !== 'connected') return;
     const id = ++lastSendId;
     // Send text and Enter separately — TUI apps (Claude Code, Codex)
     // treat \r inside a pasted block as a literal, not as confirmation.