Skip to content

Add pre-commit with basic checks#142

Merged
jbampton merged 1 commit into
mainfrom
add-pre-commit-config
Dec 18, 2025
Merged

Add pre-commit with basic checks#142
jbampton merged 1 commit into
mainfrom
add-pre-commit-config

Conversation

@jbampton

Copy link
Copy Markdown
Member

No description provided.

@jbampton jbampton self-assigned this Dec 18, 2025
@jbampton jbampton added this to Turbo Dec 18, 2025
@jbampton jbampton moved this to In Progress in Turbo Dec 18, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a robust foundation for code quality by integrating "pre-commit" hooks into the development workflow. It introduces automated checks to ensure code consistency and prevent common errors, leading to a cleaner and more maintainable codebase. The changes also include an initial cleanup of existing files to align with the newly enforced standards.

Highlights

  • Pre-commit Integration: Introduced a ".pre-commit-config.yaml" file to automate code quality checks before commits are made.
  • Automated Code Checks: Configured a suite of basic checks including AST validation, case conflict detection, private key detection, and various whitespace and line ending enforcements.
  • Codebase Cleanup: Applied automatic fixes for trailing whitespace across several files ("docs/script.js", "fetch.py", "layouts/layout.html", "render.py") as a result of the new pre-commit standards.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/pre-commit.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jbampton jbampton added github_actions Pull requests that update GitHub Actions code yaml tests javascript python html labels Dec 18, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pre-commit configuration, which is an excellent step towards automating code quality checks. The changes primarily consist of adding the .pre-commit-config.yaml file and applying the trailing-whitespace hook to existing files. My review includes a critical fix for an invalid revision in the configuration that would prevent it from working, and a suggestion to add more powerful hooks for Python code formatting and linting to further enhance the setup.

Comment thread .pre-commit-config.yaml
Comment thread .pre-commit-config.yaml
@jbampton jbampton merged commit 94d7a1f into main Dec 18, 2025
2 of 3 checks passed
@jbampton jbampton deleted the add-pre-commit-config branch December 18, 2025 18:00
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Turbo Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code html javascript python tests yaml

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant