Skip to content

Hide "Showing 0 of 0 developers" on the initial and loading states#143

Merged
BaseMax merged 8 commits into
john-bampton:mainfrom
romeu-maleiane:fix/hide-Showing-0-of-0-developers
Dec 21, 2025
Merged

Hide "Showing 0 of 0 developers" on the initial and loading states#143
BaseMax merged 8 commits into
john-bampton:mainfrom
romeu-maleiane:fix/hide-Showing-0-of-0-developers

Conversation

@romeu-maleiane

Copy link
Copy Markdown
Contributor
  • Fixed the “Showing 0 of 0 developers” issue during initial and loading states by setting the component to display: none by default, and resolved a conflict caused by a !important rule on the display property in the loading state.

#133

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@romeu-maleiane romeu-maleiane changed the title Hide "Showing 0 of 0 developers" on the initial and loading state #133 Hide "Showing 0 of 0 developers" on the initial and loading states Dec 18, 2025
@jbampton jbampton self-assigned this Dec 18, 2025
@jbampton jbampton added this to Turbo Dec 18, 2025
@jbampton jbampton moved this to In Progress in Turbo Dec 18, 2025
@jbampton jbampton added this to the December 2025 milestone Dec 18, 2025
@jbampton jbampton marked this pull request as draft December 19, 2025 14:58

@jbampton jbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you deleting all the avatars ?

@deepsource-io

deepsource-io Bot commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Here's the code health analysis summary for commits 6ac7ca8..30ad1ff. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@romeu-maleiane

Copy link
Copy Markdown
Contributor Author

Sorry, I accidentally deleted the avatars, but I recovered them.

@BaseMax BaseMax marked this pull request as ready for review December 21, 2025 21:21
@BaseMax

BaseMax commented Dec 21, 2025

Copy link
Copy Markdown
Member

This branch has conflicts that must be resolved

@BaseMax

BaseMax commented Dec 21, 2025

Copy link
Copy Markdown
Member

Sorry, I accidentally deleted the avatars, but I recovered them.

Please double check all of your works again to make sure everything is well on your end before pining me again to do final review before merging.

@romeu-maleiane

Copy link
Copy Markdown
Contributor Author

This branch has conflicts that must be resolved

I've already resolved the conflicts.
Could you do the final review?

@BaseMax

BaseMax commented Dec 21, 2025

Copy link
Copy Markdown
Member

It seems you removed all of your js changes. are you sure you did test it well?

See file changings: only css and users.json. so what about js and logic?

https://github.com/john-bampton/john-bampton.github.io/pull/143/changes

@romeu-maleiane

Copy link
Copy Markdown
Contributor Author

It seems you removed all of your js changes. are you sure you did test it well?

I’ve restored the js changes in the latest commit, I tested locally and all the changes works fine

@BaseMax BaseMax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread docs/script.js Outdated
@BaseMax BaseMax merged commit 49af507 into john-bampton:main Dec 21, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Turbo Dec 21, 2025
@BaseMax

BaseMax commented Dec 21, 2025

Copy link
Copy Markdown
Member

This was a super easy task and took long time. we need to speed up and progress faster.

Best and happy Yalda Night.

@romeu-maleiane

Copy link
Copy Markdown
Contributor Author

Sorry it took longer than expected. I’ll make sure to move faster and deliver quicker on upcoming tasks.
Best wishes and happy Yalda Night.

@jbampton jbampton linked an issue Dec 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

SUPER EASY: On the initial and loading state we should hide "Showing 0 of 0 developers" (this is a step before showing the loading)

3 participants