Skip to content

Add Most/Least Gists sorting filter #144

Merged
jbampton merged 10 commits into
john-bampton:mainfrom
Cima9642:fix-issue-141
Dec 19, 2025
Merged

Add Most/Least Gists sorting filter #144
jbampton merged 10 commits into
john-bampton:mainfrom
Cima9642:fix-issue-141

Conversation

@Cima9642

Copy link
Copy Markdown
Contributor

Summary

Adds sorting functionality for public gists count, allowing users to sort developers by "Most Gists" and "Least Gists".

Changes Made

  • Added gists-desc and gists-asc sort options to the filter dropdown
  • Updated prepareUserFromJson() to extract and store gists field from user data
  • Implemented sorting comparative functions for gists in getSortedUsers()
  • Updated .gitignore to exclude venv/ directory

Related Issue

Fixes #141

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Cima9642, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's user filtering capabilities by integrating sorting based on the number of public gists. Users can now easily find developers with the most or fewest gists, providing a more comprehensive way to explore user profiles. The changes involve updating the data processing, sorting logic, and user interface to support this new functionality.

Highlights

  • New Sorting Options: Introduced 'Most Gists' and 'Least Gists' as new sorting options in the user interface, allowing users to filter developers based on their public gist count.
  • Data Extraction: Modified the prepareUserFromJson function to correctly extract and store the public_gists field from user data, making this information available for sorting.
  • Sorting Logic: Implemented the necessary comparative functions within getSortedUsers to handle the new 'gists-desc' and 'gists-asc' sorting criteria.
  • Git Ignore Update: Added the venv/ directory to .gitignore to prevent virtual environment files from being tracked by version control.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively introduces a new sorting filter for developers based on their public gist count. The implementation correctly updates the JavaScript logic to handle the new gists property and adds the corresponding options to the HTML filter dropdown. The changes are concise and well-targeted. I have one minor suggestion to improve code formatting.

Comment thread layouts/layout.html Outdated
@jbampton jbampton self-assigned this Dec 19, 2025
@jbampton jbampton added the good first issue Good for newcomers label Dec 19, 2025
@jbampton jbampton added this to Turbo Dec 19, 2025
@jbampton jbampton moved this to In Progress in Turbo Dec 19, 2025
@jbampton jbampton added this to the December 2025 milestone Dec 19, 2025

@jbampton jbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thanks !! 🥇

@jbampton jbampton requested a review from BaseMax December 19, 2025 14:40
@jbampton jbampton merged commit 0cbdd90 into john-bampton:main Dec 19, 2025
1 of 2 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Turbo Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add sort by least and most gists

2 participants