Skip to content

Add black with pre-commit; format Python code#146

Merged
jbampton merged 2 commits into
mainfrom
pre-commit-add-black
Dec 19, 2025
Merged

Add black with pre-commit; format Python code#146
jbampton merged 2 commits into
mainfrom
pre-commit-add-black

Conversation

@jbampton

Copy link
Copy Markdown
Member

No description provided.

@jbampton jbampton self-assigned this Dec 19, 2025
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 19, 2025

Copy link
Copy Markdown

Deploying john-bampton with  Cloudflare Pages  Cloudflare Pages

Latest commit: 989b6d7
Status: ✅  Deploy successful!
Preview URL: https://d14d3555.john-bampton.pages.dev
Branch Preview URL: https://pre-commit-add-black.john-bampton.pages.dev

View logs

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to standardize the Python codebase's style by adopting the black formatter. It sets up black as a pre-commit hook to automate formatting and applies these style changes to the existing fetch.py and render.py scripts, improving readability and maintainability.

Highlights

  • Code Formatting: Introduced the black code formatter to enforce a consistent style across Python files.
  • Pre-commit Hook Integration: Integrated black into the .pre-commit-config.yaml to automatically format Python code before commits, ensuring style consistency.
  • Python Code Reformatting: Applied black to existing Python files (fetch.py and render.py), resulting in changes to string literal quotes, line wrapping, and spacing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jbampton jbampton added this to Turbo Dec 19, 2025
@jbampton jbampton moved this to In Progress in Turbo Dec 19, 2025
@jbampton jbampton added this to the December 2025 milestone Dec 19, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces black for consistent Python code formatting and applies it across the codebase. The changes in the Python files are purely stylistic and look good. However, there is a critical issue in the .pre-commit-config.yaml file where an invalid version for the black hook is specified, which will cause pre-commit to fail. I've left a comment with a suggestion to fix it.

Comment thread .pre-commit-config.yaml
@jbampton jbampton merged commit 9ca321c into main Dec 19, 2025
13 of 34 checks passed
@jbampton jbampton deleted the pre-commit-add-black branch December 19, 2025 14:55
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Turbo Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant