Publish locked Netlify production deploys after CI#99
Draft
john-kurkowski wants to merge 2 commits into
Draft
Conversation
Let Netlify build production deploys and have GitHub Actions publish the matching deploy only after CI passes.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
Record the locked auto-publishing invariant and explain why GitHub Actions publishes Netlify-built production deploys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Production deploys currently come from GitHub Actions building the site and uploading
distdirectly to Netlify. That works, but it creates duplicate production deploy entries because Netlify also observes the production branch.This changes the model so Netlify owns production builds, while GitHub Actions acts as the CI gate that publishes the matching Netlify-built deploy only after checks pass. Auto publishing is locked in Netlify, so production deploys are built but not made live until GHA explicitly publishes the deploy for the pushed commit.
Changes
ignorerule fromnetlify.toml.src/scripts/publish-netlify-production-deploy.tsto:GITHUB_SHAmasterandproductiontsxas a direct dev dependency for running the TypeScript script in CI.Test Plan
masterbranch and confirm Netlify still creates a normal Deploy Preview.masterand confirm Netlify creates a production deploy but does not publish it automatically while auto publishing is locked.