docs: correct default cache_dir description in TLDExtract docstring#367
Open
SAY-5 wants to merge 1 commit into
Open
docs: correct default cache_dir description in TLDExtract docstring#367SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TLDExtract.__init__docstring says "By default, thecache_dirwill live in the tldextract directory." That is actually the fallback path.get_cache_dir()follows the XDG Base Directory standard first (e.g.$HOME/.cache/python-tldextract) and only uses the package directory (.suffix_cache) when noTLDEXTRACT_CACHE,XDG_CACHE_HOME, orHOMEis available.The README already documents the XDG default ("caches it indefinitely in
$HOME/.cache/python-tldextract"), so this aligns the docstring with both the code and the README.ruff check,ruff format --check, and import all pass on the changed file.