Merge files, replace typedefs w/ stddef.h, etc.#1
Conversation
| @@ -1,59 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
We may want to keep this file but with just a #include <sys/errno.h>
| @@ -1,25 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
We may want to keep this file but with just a #include <sys/fcntl.h>
| @@ -1,33 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
We may want to keep this file but with just a #include <sys/file.h>
| @@ -1,44 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
We may want to keep this file but with just a #include <sys/ioctl.h>
| /* | ||
| * $PSLibId: Run-time Library Release 4.7$ | ||
| */ | ||
| #ifndef _R3000_H |
There was a problem hiding this comment.
I don't think this file, r3000.h, is even needed here.
|
|
||
| /* don't change these macros and structures which is referred in mcx code */ | ||
|
|
||
| #ifndef TRUE |
There was a problem hiding this comment.
Ok so I think these TRUE/FALSE/ERROR are actually used for the return values of the functions in here.
|
|
||
| /* don't change these macros and structures which is referred in controler code */ | ||
|
|
||
| #ifndef TRUE |
There was a problem hiding this comment.
Same here. So we may want to keep these TRUE/FALSE/ERROR blocks, or move them to a new header by itself, like sys/return_values.h, and include it from these two files, as the values are basically implicitly needed to evaluate the return values of the functions. Could also probably do with an enum instead, but that's probably too big of a change.
| @@ -1,80 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
We may want to keep this file but with just a #include <sys/types.h>
| #ifndef _SIZE_T | ||
| #define _SIZE_T | ||
| typedef unsigned int size_t; /* result type of the sizeof operator (ANSI) */ | ||
| #endif |
There was a problem hiding this comment.
Later in this file (as I can't comment somewhere as low), we may want to change this line:
#define strdup(p) ( strcpy(malloc(strlen(p)+1),p); )
to
#define strdup(p) do { strcpy(malloc(strlen(p)+1),p); } while(0)
2 participants
No description provided.