Header updates 2025#3
Open
johnbaumann wants to merge 8 commits into
Open
Conversation
(cherry picked from commit 5f56134)
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README file to document header fixes and improvements for version 2025.
- Clarifies and fixes header description for gte bytecode/macros.
- Redirects duplicate header entries to the sys directory.
- Updates definitions for L3/R3, stddef.h usage, and enhances the strdup macro.
Files not reviewed (19)
- include/errno.h: Language not supported
- include/fcntl.h: Language not supported
- include/file.h: Language not supported
- include/fs.h: Language not supported
- include/inline_n.h: Language not supported
- include/ioctl.h: Language not supported
- include/kernel.h: Language not supported
- include/libetc.h: Language not supported
- include/libgs.h: Language not supported
- include/libmcx.h: Language not supported
- include/libpad.h: Language not supported
- include/libsn.h: Language not supported
- include/libsnd.h: Language not supported
- include/malloc.h: Language not supported
- include/memory.h: Language not supported
- include/qsort.h: Language not supported
- include/stddef.h: Language not supported
- include/stdio.h: Language not supported
- include/strings.h: Language not supported
| # Bug Fixes | ||
| - libgpu.h Protect against possible alignment issues in DISPENV, fix contributed by StiNKz | ||
| - stdarg.h Deleted, as this is a compiler specific implementation and gcc has its own | ||
| - Fix error in gte bytecode/macros for gte_gpl0 and gte_gpl0_b where an extra byte was included, identified by <vini> cius |
There was a problem hiding this comment.
The term 'cius' appears to be a typo. Please verify and correct it if necessary.
Suggested change
| - Fix error in gte bytecode/macros for gte_gpl0 and gte_gpl0_b where an extra byte was included, identified by <vini> cius | |
| - Fix error in gte bytecode/macros for gte_gpl0 and gte_gpl0_b where an extra byte was included, identified by <vini> |
johnbaumann
commented
Sep 20, 2025
| #endif | ||
|
|
||
| #define strdup(p) ( strcpy(malloc(strlen(p)+1),p); ) | ||
| #define strdup(p) do { strcpy(malloc(strlen(p) + 1), p); } while (0) |
Owner
Author
There was a problem hiding this comment.
Need to re-examine this macro, strcpy returns a char*, but wrapping the function like so will not return the value.
There was a problem hiding this comment.
Oh, yeah, that's actually broken. Might be better doing this with a static inline.
|
Yep, looks all good from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.