Enable PHPStan scanning of the acceptance tests.

Author: johnbillion

phpstan.neon.dist

@@ -7,7 +7,7 @@ parameters:
 	paths:
 		- wp-crontrol.php
 		- src/
-		# - tests/acceptance/
+		- tests/acceptance/
 		- tests/integration/
 	scanDirectories:
 		- tests/_support/

tests/acceptance/AddEventCest.php

@@ -7,18 +7,18 @@
  * Test class.
  */
 class AddEventCest {
-	public function _before( AcceptanceTester $I ) {
+	public function _before( AcceptanceTester $I ): void {
 		$I->loginAsAdmin();
 	}
 
-	public function NavigatingToTheAddCronEventScreen( AcceptanceTester $I ) {
+	public function NavigatingToTheAddCronEventScreen( AcceptanceTester $I ): void {
 		$I->amOnCronEventListingPage();
 		$I->click( 'Add New Cron Event', '#wpbody' );
 		$I->see( 'Add Cron Event', 'h1' );
 		$I->see( 'Add Cron Event', '#crontrol-header' );
 	}
 
-	public function AddingANewEvent( AcceptanceTester $I ) {
+	public function AddingANewEvent( AcceptanceTester $I ): void {
 		$I->amOnCronEventListingPage();
 		$I->click( 'Add New Cron Event', '#wpbody' );
 		$I->dontSee( 'PHP Code', '#crontrol_form th' );
@@ -31,7 +31,7 @@ public function AddingANewEvent( AcceptanceTester $I ) {
 		$I->seeAdminSuccessNotice( 'Saved the cron event my_hookname.' );
 	}
 
-	public function AddingANewURLEvent( AcceptanceTester $I ) {
+	public function AddingANewURLEvent( AcceptanceTester $I ): void {
 		$I->amOnCronEventListingPage();
 		$I->click( 'Add New Cron Event', '#wpbody' );
 		$I->dontSee( 'PHP Code', '#crontrol_form th' );
@@ -48,7 +48,7 @@ public function AddingANewURLEvent( AcceptanceTester $I ) {
 		$I->see( 'https://example.org/' );
 	}
 
-	public function AddingANewURLEventWithDisallowedURLShowsError( AcceptanceTester $I ) {
+	public function AddingANewURLEventWithDisallowedURLShowsError( AcceptanceTester $I ): void {
 		$I->amOnCronEventListingPage();
 		$I->click( 'Add New Cron Event', '#wpbody' );
 		$I->selectOption( 'input[name="crontrol_action"]', 'URL cron event' );
@@ -63,7 +63,7 @@ public function AddingANewURLEventWithDisallowedURLShowsError( AcceptanceTester
 		$I->dontSee( 'Run now', $row );
 	}
 
-	public function AddingANewPHPEvent( AcceptanceTester $I ) {
+	public function AddingANewPHPEvent( AcceptanceTester $I ): void {
 		$I->amOnCronEventListingPage();
 		$I->click( 'Add New Cron Event', '#wpbody' );
 		$I->dontSee( 'PHP Code', '#crontrol_form th' );

tests/acceptance/AddScheduleCest.php

@@ -7,18 +7,18 @@
  * Test class.
  */
 class AddScheduleCest {
-	public function _before( AcceptanceTester $I ) {
+	public function _before( AcceptanceTester $I ): void {
 		$I->loginAsAdmin();
 	}
 
-	public function NavigatingToTheAddCronSchedulesScreen( AcceptanceTester $I ) {
+	public function NavigatingToTheAddCronSchedulesScreen( AcceptanceTester $I ): void {
 		$I->amOnCronScheduleListingPage();
 		$I->see( 'Cron Schedules', '#crontrol-header' );
 		$I->see( 'Cron Schedules', 'h1' );
 		$I->see( 'Add Cron Schedule', 'h2' );
 	}
 
-	public function AddingANewSchedule( AcceptanceTester $I ) {
+	public function AddingANewSchedule( AcceptanceTester $I ): void {
 		$I->amOnCronScheduleListingPage();
 		$I->fillField( 'Internal Name', 'my_schedule_name' );
 		$I->fillField( 'Interval (seconds)', '123' );

tests/acceptance/DeleteAllWithHookCest.php

@@ -7,11 +7,11 @@
  * Test class.
  */
 class DeleteAllWithHookCest {
-	public function _before( AcceptanceTester $I ) {
+	public function _before( AcceptanceTester $I ): void {
 		$I->loginAsAdmin();
 	}
 
-	public function DeletingAHook( AcceptanceTester $I ) {
+	public function DeletingAHook( AcceptanceTester $I ): void {
 		$I->amWorkingWithANewCronEvent( 'example_hook', '[1]' );
 		$I->amWorkingWithANewCronEvent( 'example_hook', '[2]' );
 		$row = $I->amWorkingWithANewCronEvent( 'example_hook', '[3]' );
@@ -23,7 +23,7 @@ public function DeletingAHook( AcceptanceTester $I ) {
 		$I->dontSee( 'example_hook', '.crontrol-events' );
 	}
 
-	public function DeletingAPersistentWordPressCoreHook( AcceptanceTester $I ) {
+	public function DeletingAPersistentWordPressCoreHook( AcceptanceTester $I ): void {
 		$I->amWorkingWithANewCronEvent( 'wp_scheduled_delete', '[1]' );
 		$I->amWorkingWithANewCronEvent( 'wp_scheduled_delete', '[2]' );
 		$row = $I->amWorkingWithANewCronEvent( 'wp_scheduled_delete', '[3]' );

tests/acceptance/ListEventsCest.php

@@ -7,11 +7,11 @@
  * Test class.
  */
 class ListEventsCest {
-	public function _before( AcceptanceTester $I ) {
+	public function _before( AcceptanceTester $I ): void {
 		$I->loginAsAdmin();
 	}
 
-	public function ListCronEvents( AcceptanceTester $I ) {
+	public function ListCronEvents( AcceptanceTester $I ): void {
 		$I->amOnCronEventListingPage();
 		$I->see( 'Cron Events', 'h1' );
 		$I->see( 'Cron Events', '#crontrol-header' );

tests/acceptance/PauseEventCest.php

@@ -7,11 +7,11 @@
  * Test class.
  */
 class PauseEventCest {
-	public function _before( AcceptanceTester $I ) {
+	public function _before( AcceptanceTester $I ): void {
 		$I->loginAsAdmin();
 	}
 
-	public function PausingAnEvent( AcceptanceTester $I ) {
+	public function PausingAnEvent( AcceptanceTester $I ): void {
 		$row = $I->amWorkingWithANewCronEvent( 'pause_me_soon' );
 
 		$I->click( 'Pause', $row );