Make better use of exceptions#193
Merged
Merged
Conversation
johnbillion
marked this pull request as ready for review
October 11, 2025 12:05
…ogged when the event runs.
…rl()` with a narrower list of protocols.
…ntext of a cron event, not a regular web request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This promotes error conditions within cron callbacks to exceptions which are more likely to be seen in logs and monitoring systems. The exceptions are not caught by WP Crontrol.This implements a better control structure using exceptions, but it does not leave the exceptions uncaught due to the concerns listed below. Warnings will continue to be triggered as they were prior to this change.
Concerns
If an event triggers an exception: