Make better use of exceptions

docker-compose.yml

@@ -2,3 +2,11 @@ include:
   -
     path: vendor/johnbillion/plugin-infrastructure/tests/docker-compose.yml
     project_directory: .
+
+services:
+  httpbin:
+    image: mccutchen/go-httpbin:latest
+    container_name: ${COMPOSE_PROJECT_NAME}-httpbin
+    restart: always
+    environment:
+      PORT: 80

phpcs.xml.dist

@@ -39,6 +39,9 @@
 		<exclude name="Universal.Arrays.DisallowShortArraySyntax.Found"/>
 		<exclude name="WordPress.PHP.YodaConditions.NotYoda"/>
 		<exclude name="Universal.Operators.DisallowShortTernary.Found"/>
+
+		<!-- Exceptions in WP Crontrol are caught appropriately. -->
+		<exclude name="WordPress.Security.EscapeOutput.ExceptionNotEscaped"/>
 	</rule>
 
 	<!-- Ignore some rules for the tests -->

phpunit.xml.dist

@@ -11,6 +11,7 @@
 	convertErrorsToExceptions="true"
 	convertNoticesToExceptions="true"
 	convertWarningsToExceptions="true"
+	failOnRisky="true"
 	>
 	<testsuites>
 		<testsuite name="integration">

src/Event/Event.php

@@ -10,6 +10,7 @@
 use Crontrol\Event\CoreCronEvent;
 use Crontrol\Event\ActionSchedulerEvent;
 use Crontrol\Event\StandardEvent;
+use Crontrol\Exception\UnknownScheduleException;
 
 /**
  * Base class for cron events.
@@ -278,7 +279,7 @@ public function is_persistent_core_hook(): bool {
 	 * Get the schedule name for this event.
 	 *
 	 * @return string The schedule display name.
-	 * @throws \RuntimeException If schedule is unknown.
+	 * @throws UnknownScheduleException If schedule is unknown.
 	 */
 	public function get_schedule_name(): string {
 		if ( ! $this->is_recurring() ) {
@@ -291,13 +292,11 @@ public function get_schedule_name(): string {
 			return isset( $schedules[ $this->schedule ]['display'] ) ? $schedules[ $this->schedule ]['display'] : $schedules[ $this->schedule ]['name'];
 		}
 
-		throw new \RuntimeException(
-			esc_html(
-				sprintf(
-					/* translators: %s: Schedule name */
-					__( 'Unknown (%s)', 'wp-crontrol' ),
-					$this->schedule
-				)
+		throw new UnknownScheduleException(
+			sprintf(
+				/* translators: %s: Schedule name */
+				__( 'Unknown (%s)', 'wp-crontrol' ),
+				$this->schedule
 			)
 		);
 	}

src/Exception/CrontrolRuntimeException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown for WP Crontrol runtime errors.
+ */
+class CrontrolRuntimeException extends \RuntimeException {}

src/Exception/HTTPFailedException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown when an HTTP request fails.
+ */
+class HTTPFailedException extends CrontrolRuntimeException {}

src/Exception/InvalidHashException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown when a hash is invalid for a cron event.
+ */
+class InvalidHashException extends CrontrolRuntimeException {}

src/Exception/InvalidURLException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown when a URL is invalid for a cron event.
+ */
+class InvalidURLException extends CrontrolRuntimeException {}

src/Exception/MissingHashException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown when a hash is missing for a cron event.
+ */
+class MissingHashException extends CrontrolRuntimeException {}

src/Exception/MissingURLException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown when a URL is missing for a cron event.
+ */
+class MissingURLException extends CrontrolRuntimeException {}

src/Exception/UnexpectedHTTPCodeException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown when an unexpected HTTP response code is received.
+ */
+class UnexpectedHTTPCodeException extends CrontrolRuntimeException {}

src/Exception/UnknownScheduleException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Crontrol\Exception;
+
+/**
+ * Exception thrown when a schedule name is unknown.
+ */
+class UnknownScheduleException extends CrontrolRuntimeException {}