Merge pull request #2 from johnkors/log-failed-responses

Log failed responses

Author: johnkors

samples/With/Worker.cs

@@ -24,6 +24,10 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
             {
                 _logger.LogInformation("Timeout!");
             }
+            catch(Exception e)
+            {
+                _logger.LogError(e.Message);
+            }
 
             await Task.Delay(10000, stoppingToken);
         }

samples/Without/Worker.cs

@@ -20,10 +20,14 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
             {
                 await _client.GetAsync("https://httpstat.us/404?sleep=3000", stoppingToken);
             }
-            catch (TaskCanceledException e)
+            catch (TaskCanceledException)
             {
                 _logger.LogInformation("Timeout!");
             }
+            catch(Exception e)
+            {
+                _logger.LogError(e.Message);
+            }
 
             await Task.Delay(10000, stoppingToken);
         }

source/MinimalHttpLogger/MinimalHttpLogger.cs

@@ -58,12 +58,19 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
         {
             throw new ArgumentNullException(nameof(request));
         }
-        var requestUri = request.RequestUri.ToString(); //SendAsync modifies req uri in case of redirects (?!), so making a local copy
+        var requestUri = request.RequestUri?.ToString(); //SendAsync modifies req uri in case of redirects (?!), so making a local copy
         var stopwatch = ValueStopwatch.StartNew();
-        var response = await base.SendAsync(request, cancellationToken).ConfigureAwait(false);
-        _logger.LogInformation("{Method} {Uri} - {StatusCode} {StatusCodeLiteral} in {Time}ms", request.Method, requestUri, $"{(int)response.StatusCode}", $"{response.StatusCode}", stopwatch.GetElapsedTime().TotalMilliseconds);
-
-        return response;
+        try
+        {
+            var response = await base.SendAsync(request, cancellationToken).ConfigureAwait(false);
+            _logger.LogInformation("{Method} {Uri} - {StatusCode} {StatusCodeLiteral} in {Time}ms", request.Method, requestUri, $"{(int)response.StatusCode}", $"{response.StatusCode}", stopwatch.GetElapsedTime().TotalMilliseconds);
+            return response;
+        }
+        catch(Exception)
+        {
+            _logger.LogInformation("{Method} {Uri} failed to respond in {Time}ms", request.Method, requestUri, stopwatch.GetElapsedTime().TotalMilliseconds);
+            throw;
+        }
     }
 
     internal struct ValueStopwatch