Fix separator live-refresh + appearance re-render; move color toggle to Display#20
Merged
Merged
Conversation
Addresses two review findings: - Observe menuBarSeparatorStyle in the menu observation token, so changing the Dot/Pipe picker refreshes the status item immediately instead of waiting for another observed setting or usage update. - On the macOS 26 effectiveAppearance change, clear the cached icon render signatures before updateIcons(). The signatures don't encode appearance, so an unchanged usage/status value would otherwise short-circuit the re-render and leave the stale baked (non-template) bitmap until some other input changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The toggle lived under Advanced, making it hard to find next to the other menu-bar appearance settings. Move it into Display ▸ Menu Bar (default stays on) so the disable option sits where users look for menu-bar icon options. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the review fixes from the upstream PR (steipete#1207) into the fork.
menuBarSeparatorStyleis now read by the menu observation token, so changing Dot/Pipe in preferences updates the menu-bar text immediately instead of waiting for the next observed setting/usage change.effectiveAppearanceobserver now clears the cached icon render signatures beforeupdateIcons(), so the baked non-template tint actually re-resolves on dark/light switches (the signatures don't encode appearance, so an unchanged usage value would otherwise short-circuit the re-render).swift build+lint.sh lintpass.🤖 Generated with Claude Code