Skip to content

Commit 50964d9

Browse files
johnmathewsclaude
andcommitted
Fix code review issues: kustomization, memory limits, dev key comment
- Add servicemonitor.yaml to kustomization.yaml resources list - Increase store-worker memory requests/limits (64Mi/128Mi → 128Mi/256Mi) - Add comment clarifying Azurite dev key is not a real secret - Update journal with wrap-up fixes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6e94ac2 commit 50964d9

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

docker-compose.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ services:
5555
- PYTHONPATH=/app/src
5656
- REDIS_URL=redis://redis:6379
5757
- DATABASE_URL=postgresql://documentstream:documentstream@postgres:5432/documentstream
58+
# Azurite default dev key — NOT a real secret, publicly documented at
59+
# https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite
5860
- BLOB_CONNECTION_STRING=DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://azurite:10000/devstoreaccount1;
5961
- BLOB_CONTAINER=documents
6062
depends_on:

journal/260401-azure-blob-storage-and-metrics.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,15 @@ to the Grafana dashboard, completing the storage layer of the pipeline.
9393
- ONNX Runtime is ~50MB vs ~5GB for full PyTorch — faster image pulls, faster KEDA scale-up,
9494
lower memory per classify-worker pod
9595

96+
### Wrap-up Fixes (code review)
97+
98+
- Added `servicemonitor.yaml` to `k8s/base/kustomization.yaml` — it was missing, so
99+
`kubectl apply -k k8s/base/` would silently skip it
100+
- Increased store-worker memory limits from 64Mi/128Mi to 128Mi/256Mi — Python with
101+
psycopg, azure-storage-blob, and prometheus_client exceeds 64Mi
102+
- Added comment on Azurite dev key in docker-compose.yml to prevent false positives
103+
from secret scanners
104+
96105
## Test Status
97106

98-
- 92 tests passing (up from 83), lint clean
107+
- 92 tests passing (up from 83), 88% coverage, lint clean

k8s/base/kustomization.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ resources:
1212
- configmap.yaml
1313
- gateway-deployment.yaml
1414
- gateway-service.yaml
15+
- servicemonitor.yaml
1516
- extract-deployment.yaml
1617
- classify-deployment.yaml
1718
- store-deployment.yaml

k8s/base/store-deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ spec:
4040
resources:
4141
requests:
4242
cpu: 50m
43-
memory: 64Mi
43+
memory: 128Mi
4444
limits:
4545
cpu: 200m
46-
memory: 128Mi
46+
memory: 256Mi

0 commit comments

Comments
 (0)