Add ESLint recommendations#782
Open
dopry wants to merge 1 commit intojohnpapa:masterfrom
Open
Conversation
|
Why not reference https://www.npmjs.com/package/eslint-plugin-angular? |
Author
|
Because it's much simpler to convert the existing jshint rules to eslint On Oct 24, 2016 5:44 AM, "Adri Van Houdt" notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the output of the recommended jshint and jscs options after passing through polyjuice. I also added a .eslintrc which can be downloaded from the repo as well.
Let me know if this is acceptable or if I should make any additional refinements.
closes #770
closes #696
partially addresses #732, but JSCS should probably be removed from the styleguide after a deprecation period since it is not a part of ESLint.