refactor(compat-eslint): hoist remaining lazy requires in lib + index

Three places the previous sweep missed because they imported
different names from already-hoisted modules or different modules
entirely:

  - `index.ts:buildScanPredicate` — `predicateForTriggerSet`,
    `predicateAllKinds` from `./lib/ts-ast-scan` (had `tsScanTraverse`
    only).
  - `lib/lazy-estree.ts` — `xhtmlEntities` from `./xhtml-entities`,
    used inside `unescapeJsxText`.
  - `lib/lazy-source-code.ts` and `lib/ts-scope-manager.ts` —
    both reach into `./lazy-estree` for `materialize` from a
    fallback path. No cycle: `lazy-estree` doesn't import either
    file.

Production code is now `as typeof import`-free; every dep is at
top of file. All four test suites still clean.

Author: johnsoncodehk

packages/compat-eslint/index.ts

@@ -6,7 +6,7 @@ import { convertLazy } from './lib/lazy-estree';
 import { LazySourceCode } from './lib/lazy-source-code';
 import { decomposeSimple, isCodePathListener } from './lib/selector-analysis';
 import { convertComments, convertTokens } from './lib/tokens';
-import { tsScanTraverse } from './lib/ts-ast-scan';
+import { predicateAllKinds, predicateForTriggerSet, tsScanTraverse } from './lib/ts-ast-scan';
 import { applyEslintGlobals, TsScopeManager } from './lib/ts-scope-manager';
 import { visitorKeys } from './lib/visitor-keys';
 
@@ -488,9 +488,6 @@ function buildFastDispatch(
 //     if any type lacks a registered predicate (same philosophy as
 //     decomposeSimple — surface coverage gaps as hard errors).
 function buildScanPredicate(fast: FastDispatch) {
-	const { predicateForTriggerSet, predicateAllKinds } = require(
-		'./lib/ts-ast-scan',
-	) as typeof import('./lib/ts-ast-scan');
 	const usesCodePath = fast.codePath.size > 0;
 	const usesWildcard = fast.enterAll.length > 0 || fast.exitAll.length > 0;
 	if (usesCodePath || usesWildcard) {

packages/compat-eslint/lib/lazy-estree.ts

@@ -33,6 +33,7 @@
 // these positions.
 
 import * as ts from 'typescript';
+import { xhtmlEntities } from './xhtml-entities';
 
 const SK = ts.SyntaxKind;
 
@@ -4938,7 +4939,6 @@ function convertJSXNamespaceOrIdentifier(node: ts.Node, parent: LazyNode): LazyN
 // `.value` (react/no-unescaped-entities, jsx-a11y accessibility checks,
 // whitespace detectors) need this parity — partial decoding silently
 // hides real entities behind their `&name;` source form.
-const { xhtmlEntities } = require('./xhtml-entities.js') as { xhtmlEntities: Record<string, string> };
 function unescapeJsxText(text: string): string {
 	if (!text.includes('&')) return text;
 	return text.replace(/&(?:#\d+|#x[\da-fA-F]+|[0-9a-zA-Z]+);/g, entity => {

packages/compat-eslint/lib/lazy-source-code.ts

@@ -26,6 +26,7 @@
 // returning undefined.
 
 import * as ts from 'typescript';
+import { materialize } from './lazy-estree';
 import { buildCommentObject, walkInnerCommentsOf } from './tokens';
 
 const SK = ts.SyntaxKind;
@@ -587,7 +588,6 @@ export class LazySourceCode {
 		// holds the converter context.
 		const ctx = (this.ast as { _ctx?: unknown })._ctx;
 		if (!ctx) return null;
-		const { materialize } = require('./lazy-estree') as typeof import('./lazy-estree');
 		// Walk up to find a ts.Node that has an ESTree wrapper kind.
 		// Tokens / SyntaxList / etc. get folded into their parent's
 		// ESTree shape, so they don't have their own wrappers.

packages/compat-eslint/lib/ts-scope-manager.ts

@@ -12,6 +12,7 @@
 
 import type { TSESTree } from '@typescript-eslint/types';
 import ts = require('typescript');
+import { materialize } from './lazy-estree';
 
 type AstMaps = {
 	esTreeNodeToTSNodeMap: WeakMap<TSESTree.Node, ts.Node>;
@@ -1480,9 +1481,6 @@ export class TsScopeManager {
 		// Builds a real ESTree counterpart with proper parent chain. Lazy
 		// has a generic-fallback for unsupported kinds and null returns,
 		// so this never throws.
-		const { materialize } = require(
-			'./lazy-estree',
-		) as typeof import('./lazy-estree');
 		return materialize(tsNode, {
 			ast: this.tsFile,
 			maps: this.astMaps,