fixed some inspection warnings (made more things final, reduced visibility, removed unnecessary this)

Author: firewave

src/com/github/johnthagen/cppcheck/Configuration.java

@@ -9,7 +9,7 @@
 import javax.swing.event.DocumentEvent;
 import javax.swing.event.DocumentListener;
 
-public class Configuration implements Configurable {
+class Configuration implements Configurable {
     private boolean modified = false;
     private JFilePicker cppcheckFilePicker;
     private JTextField cppcheckOptionsField;
@@ -105,7 +105,7 @@ public boolean isModified() {
     }
 
     private void setModified() {
-        this.modified = true;
+        modified = true;
     }
 
     @Override
@@ -140,22 +140,22 @@ public void disposeUIResources() {
     private static class CppcheckConfigurationModifiedListener implements DocumentListener {
         private final Configuration option;
 
-        CppcheckConfigurationModifiedListener(Configuration option) {
+        CppcheckConfigurationModifiedListener(final Configuration option) {
             this.option = option;
         }
 
         @Override
-        public void insertUpdate(DocumentEvent documentEvent) {
+        public void insertUpdate(final DocumentEvent documentEvent) {
             option.setModified();
         }
 
         @Override
-        public void removeUpdate(DocumentEvent documentEvent) {
+        public void removeUpdate(final DocumentEvent documentEvent) {
             option.setModified();
         }
 
         @Override
-        public void changedUpdate(DocumentEvent documentEvent) {
+        public void changedUpdate(final DocumentEvent documentEvent) {
             option.setModified();
         }
     }

src/com/github/johnthagen/cppcheck/CppCheckInspectionImpl.java

@@ -35,7 +35,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
-public class CppCheckInspectionImpl {
+class CppCheckInspectionImpl {
     private static ProblemHighlightType severityToHighlightType(@NotNull final String severity) {
         switch (severity) {
             case "error":
@@ -77,8 +77,8 @@ public static List<ProblemDescriptor> parseOutput(@NotNull final PsiFile psiFile
 
         final List<ProblemDescriptor> descriptors = new ArrayList<>();
 
-        DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
-        DocumentBuilder db = dbf.newDocumentBuilder();
+        final DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
+        final DocumentBuilder db = dbf.newDocumentBuilder();
         final org.w3c.dom.Document doc = db.parse(new InputSource(new StringReader(cppcheckOutput)));
 
         final NodeList errors = doc.getElementsByTagName("error");

src/com/github/johnthagen/cppcheck/CppcheckError.java

@@ -2,7 +2,7 @@
 
 import org.jetbrains.annotations.NotNull;
 
-public class CppcheckError extends Error {
+class CppcheckError extends Error {
     public CppcheckError(@NotNull final String message)
     {
         super(message);

src/com/github/johnthagen/cppcheck/CppcheckInspection.java

@@ -26,12 +26,12 @@
 import java.util.Collections;
 import java.util.List;
 
-public class CppcheckInspection extends LocalInspectionTool {
+class CppcheckInspection extends LocalInspectionTool {
     @Nullable
     @Override
-    public ProblemDescriptor[] checkFile(@NotNull PsiFile file,
-                                         @NotNull InspectionManager manager,
-                                         boolean isOnTheFly) {
+    public ProblemDescriptor[] checkFile(@NotNull final PsiFile file,
+                                         @NotNull final InspectionManager manager,
+                                         final boolean isOnTheFly) {
         final VirtualFile vFile = file.getVirtualFile();
         if (vFile == null || !vFile.isInLocalFileSystem() || !isCFamilyFile(vFile)) {
             return ProblemDescriptor.EMPTY_ARRAY;
@@ -68,7 +68,7 @@ public ProblemDescriptor[] checkFile(@NotNull PsiFile file,
             final List<ProblemDescriptor> descriptors = CppCheckInspectionImpl.parseOutput(file, manager, document, cppcheckOutput,
                     tempFile.getName());
             return descriptors.toArray(new ProblemDescriptor[0]);
-        } catch (ExecutionException | CppcheckError | IOException | SAXException | ParserConfigurationException ex) {
+        } catch (final ExecutionException | CppcheckError | IOException | SAXException | ParserConfigurationException ex) {
             Notifications.Bus.notify(new Notification("Cppcheck",
                     "Cppcheck execution failed.",
                     ex.getClass().getSimpleName() + ": " + ex.getMessage(),
@@ -83,7 +83,7 @@ public ProblemDescriptor[] checkFile(@NotNull PsiFile file,
     }
 
     @NotNull
-    private static String prependIncludeDir(@NotNull String cppcheckOptions, @NotNull VirtualFile vFile) {
+    private static String prependIncludeDir(@NotNull final String cppcheckOptions, @NotNull final VirtualFile vFile) {
         final VirtualFile dir = vFile.getParent();
         if (dir == null) {
             return cppcheckOptions;

src/com/github/johnthagen/cppcheck/JFilePicker.java

@@ -11,7 +11,7 @@ class JFilePicker extends JPanel {
     private final JTextField textField;
     private final JFileChooser fileChooser;
 
-    JFilePicker(String textFieldLabel, String buttonLabel) {
+    JFilePicker(final String textFieldLabel, final String buttonLabel) {
         fileChooser = new JFileChooser();
 
         setLayout(new FlowLayout(FlowLayout.CENTER, 5, 5));

src/com/github/johnthagen/cppcheck/Properties.java

@@ -5,11 +5,11 @@
 class Properties {
     private static final PropertiesComponent INSTANCE = PropertiesComponent.getInstance();
 
-    static void set(String key, String value) {
+    static void set(final String key, final String value) {
         INSTANCE.setValue(key, value);
     }
 
-    static String get(String key) {
+    static String get(final String key) {
         return INSTANCE.getValue(key);
     }
 }