Skip to content

fix: don't treat closing quote as escaped after an escaped backslash #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joho merged 1 commit into from
May 19, 2026
Merged

fix: don't treat closing quote as escaped after an escaped backslash #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions godotenv_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,9 @@ func TestParsing(t *testing.T) {
// parses escaped double quotes
parseAndCompare(t, `FOO="escaped\"bar"`, "FOO", `escaped"bar`)

// a trailing escaped backslash does not escape the closing quote
parseAndCompare(t, `FOO="bar\\"`, "FOO", `bar\`)

// parses single quotes inside double quotes
parseAndCompare(t, `FOO="'d'"`, "FOO", `'d'`)

Expand Down
8 changes: 6 additions & 2 deletions parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,12 @@ func extractVarValue(src []byte, vars map[string]string) (value string, rest []b
continue
}

// skip escaped quote symbol (\" or \', depends on quote)
if prevChar := src[i-1]; prevChar == '\\' {
// skip escaped quote symbol; a quote is escaped only when preceded by an odd number of backslashes
backslashes := 0
for j := i - 1; j >= 0 && src[j] == '\\'; j-- {
backslashes++
}
if backslashes%2 == 1 {
continue
}

Expand Down
Loading