Add type checking with MyPy to tests#601
Open
brianhelba wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
This currently depends on changed from #602 in order for the new tests to pass cleanly. Assuming that's merged, I'll rebase this on top. |
brianhelba
force-pushed
the
mypy
branch
2 times, most recently
from
cb990dd to
8798b85
Compare
Owner
|
Hi @brianhelba |
Contributor
Author
|
@joke2k Ready for review. |
Contributor
Author
|
@joke2k Ping. If there's interest in this, I'd be happy to help with getting broader typing support, so we can close python/typeshed#14573 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds a
py.typedfile, which is mandatory to allow downstream packages to read any type information from this project: https://peps.python.org/pep-0561/