Php 8 Fixes and Memory Support#191
Open
danielbeardsley wants to merge 7 commits into
Open
Conversation
Easier to read / maintian this way.
Xdebug has supported memory for a while, but this tool hadn't been updated to use it. Here we add a new "costFormat" option of "bytes of memory". We pass this through to the pre-processor to have it read the memory cost field instead of the time cost field.
Just like the PHP pre-processor, we read the memory if costFormat == 'bytes'.
Some other pull upgraded jQuery and that caused this jQuery plugin to crash. Stubbing this "browser" object will allow expressions like "$.browser.ie" to return undefined instead of throwing.
Previously, the tablesorter was detecting numeric values with thousands separators as "text" and sorting them incorrectly. I added thousands separators for bytes values, so they are easier to read at a glance as the numbers get long but the sorter hadn't been parsing them well. Note: I'm not sure why the "Cost" column was set to "sorter: false" on the subtables, it had still been sorting but it had been falling back to auto-detecting the sort type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally pull #174, resubmitted on a feature branch instead of master because we pushed unrelated changes to our master.
Support retrieving and using the memory information that XDebug records.
Adding "memory" as cost format option was the easiest way to get it done.
This also adds the php 8.2 fixes in #169 (thanks @mmcev106)
Closes #51
Note: This went through a lot of CR and QA in our fork: iFixit#1