Merge pull request #27 from jonabc/don't-add-null-card-to-column

Check the return value when adding a card via the API

Author: jonabc

dist/index.js

@@ -6223,10 +6223,14 @@ async function ensureCardAtIndex(column, toIndex, findCardFunc, newCardFunc) {
   if (!card) {
     // add card to remote project column cards
     card = await api.addCardToColumn(column, newCardFunc());
-    currentIndex = 0;
 
-    // add the card to the local column cards
-    column.cards.nodes.splice(0, 0, card);
+    // add card to local project column cards if API was successful
+    if (card) {
+      currentIndex = 0;
+
+      // add the card to the local column cards
+      column.cards.nodes.splice(0, 0, card);
+    }
   }
 
   if (card && currentIndex !== toIndex) {

src/linked-project-columns.js

@@ -26,10 +26,14 @@ async function ensureCardAtIndex(column, toIndex, findCardFunc, newCardFunc) {
   if (!card) {
     // add card to remote project column cards
     card = await api.addCardToColumn(column, newCardFunc());
-    currentIndex = 0;
 
-    // add the card to the local column cards
-    column.cards.nodes.splice(0, 0, card);
+    // add card to local project column cards if API was successful
+    if (card) {
+      currentIndex = 0;
+
+      // add the card to the local column cards
+      column.cards.nodes.splice(0, 0, card);
+    }
   }
 
   if (card && currentIndex !== toIndex) {

test/linked-project-columns.test.js

@@ -207,6 +207,20 @@ describe('linked-project-columns', () => {
     expect(api.moveCardToIndex.getCall(0).args).toEqual([targetColumn, 0, 1]);
   });
 
+  it('does not add a card to the local target column when the remote call fails', async () => {
+    sourceColumns[0].cards.nodes.push({ id: 1, note: '1' });
+    // when the remote call fails, addCardToColumn returns null.  overwrite
+    // the default method stub to return null.
+    api.addCardToColumn.returns(null);
+
+    await run();
+    expect(targetColumn.cards.nodes).toEqual([]);
+
+    expect(api.addCardToColumn.callCount).toEqual(1);
+    expect(api.addCardToColumn.getCall(0).args).toEqual([targetColumn, { id: 1, note: '1' }]);
+    expect(api.moveCardToIndex.callCount).toEqual(0);
+  });
+
   it('moves cards on the target to match the source', async () => {
     sourceColumns[0].cards.nodes.push({ id: 1, note: '1' }, { id: 2, note: '2' });
     targetColumn.cards.nodes.push({ id: 202, note: '2' }, { id: 201, note: '1' });