Remove elixir v1.19 deprecation warnings (#96)

* Remove elixir v1.19 deprecation warnings

* Add elixir v1.19 to CI

* Update lib/ex_json_schema/schema/ref.ex

Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>

* Update lib/ex_json_schema/schema/ref.ex

Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>

* Apply suggestions from code review

Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>

---------

Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>

Author: san650

.github/workflows/ci.yml

@@ -19,6 +19,8 @@ jobs:
             otp: 25.3.2.9
           - elixir: 1.18.1
             otp: 27.2
+          - elixir: 1.19.4
+            otp: 28.3
     env:
       MIX_ENV: test
     steps:

lib/ex_json_schema/schema.ex

@@ -122,7 +122,7 @@ defmodule ExJsonSchema.Schema do
     end
 
     root = %Root{root | version: schema_version}
-    {root, schema} = resolve_with_root(root, root_schema, scope)
+    {%Root{} = root, schema} = resolve_with_root(root, root_schema, scope)
 
     %Root{root | schema: schema}
     |> resolve_refs(schema)
@@ -366,5 +366,5 @@ defmodule ExJsonSchema.Schema do
     do: raise(InvalidReferenceError, message: "invalid reference #{ref}")
 
   def raise_invalid_reference_error(ref),
-    do: ref |> to_string() |> raise_invalid_reference_error
+    do: ref |> to_string() |> raise_invalid_reference_error()
 end

lib/ex_json_schema/schema/ref.ex

@@ -29,9 +29,9 @@ defmodule ExJsonSchema.Schema.Ref do
     %__MODULE__{location: location} |> parse_fragment(fragment)
   end
 
-  defp parse_fragment(ref, fragment) when fragment in [nil, ""], do: %__MODULE__{ref | fragment: []}
+  defp parse_fragment(%__MODULE__{} = ref, fragment) when fragment in [nil, ""], do: %__MODULE__{ref | fragment: []}
 
-  defp parse_fragment(ref, "/" <> _ = pointer) do
+  defp parse_fragment(%__MODULE__{} = ref, "/" <> _ = pointer) do
     keys = unescaped_ref_segments(pointer)
 
     pointer =
@@ -45,7 +45,7 @@ defmodule ExJsonSchema.Schema.Ref do
     %__MODULE__{ref | fragment: pointer, fragment_pointer?: true}
   end
 
-  defp parse_fragment(ref, id), do: %__MODULE__{ref | fragment: [id]}
+  defp parse_fragment(%__MODULE__{} = ref, id), do: %__MODULE__{ref | fragment: [id]}
 
   defp unescaped_ref_segments(ref) do
     ref

mix.exs

@@ -18,7 +18,6 @@ defmodule ExJsonSchema.Mixfile do
       package: package(),
       elixirc_paths: elixirc_paths(Mix.env()),
       test_coverage: [tool: ExCoveralls],
-      preferred_cli_env: [coveralls: :test, dialyzer: :test],
       dialyzer: [
         plt_add_apps: [:ex_unit]
       ]
@@ -29,6 +28,10 @@ defmodule ExJsonSchema.Mixfile do
     [extra_applications: []]
   end
 
+  def cli do
+    [preferred_envs: [coveralls: :test, dialyzer: :test]]
+  end
+
   defp deps do
     [
       {:decimal, "~> 2.0"},