Remove elixir v1.19 deprecation warnings#96
Conversation
jonasschmidt
left a comment
There was a problem hiding this comment.
Thank you for taking the time to look into this. My preference would be to fix those warnings by adding type checks through pattern-matches, instead of removing type information. See my comments for some suggestions on how to make the compiler happy.
Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>
Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>
Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>
|
Thanks for the suggestions @jonasschmidt. I've applied your suggestions and I think the PR is ready to go 💪 |
|
Nice, thank you. There were some unrelated build failures that I fixed in |
|
Ok, found an unrelated issue caused by OTP 28 switching to a different regex engine, which was failing some tests in the official JSON Schema test suite. That's fixed now as well, and the shiny new version |
|
Thanks @jonasschmidt |
After
Before