Skip to content

Remove elixir v1.19 deprecation warnings #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonasschmidt merged 5 commits into from
Dec 15, 2025
Merged

Remove elixir v1.19 deprecation warnings #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0471ff3
Remove elixir v1.19 deprecation warnings
san650 Dec 4, 2025
2b3105d
Add elixir v1.19 to CI
san650 Dec 4, 2025
1566a54
Update lib/ex_json_schema/schema/ref.ex
san650 Dec 12, 2025
02564e4
Update lib/ex_json_schema/schema/ref.ex
san650 Dec 12, 2025
b6f9951
Apply suggestions from code review
san650 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
otp: 24.3.4.17
- elixir: 1.18.1
otp: 27.2
- elixir: 1.19.4
otp: 28.3
env:
MIX_ENV: test
steps:
Expand Down
4 changes: 2 additions & 2 deletions lib/ex_json_schema/schema.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ defmodule ExJsonSchema.Schema do
end

root = %Root{root | version: schema_version}
{root, schema} = resolve_with_root(root, root_schema, scope)
{%Root{} = root, schema} = resolve_with_root(root, root_schema, scope)

%Root{root | schema: schema}
|> resolve_refs(schema)
Expand Down Expand Up @@ -366,5 +366,5 @@ defmodule ExJsonSchema.Schema do
do: raise(InvalidReferenceError, message: "invalid reference #{ref}")

def raise_invalid_reference_error(ref),
do: ref |> to_string() |> raise_invalid_reference_error
do: ref |> to_string() |> raise_invalid_reference_error()
end
6 changes: 3 additions & 3 deletions lib/ex_json_schema/schema/ref.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ defmodule ExJsonSchema.Schema.Ref do
%__MODULE__{location: location} |> parse_fragment(fragment)
end

defp parse_fragment(ref, fragment) when fragment in [nil, ""], do: %__MODULE__{ref | fragment: []}
defp parse_fragment(%__MODULE__{} = ref, fragment) when fragment in [nil, ""], do: %__MODULE__{ref | fragment: []}

defp parse_fragment(ref, "/" <> _ = pointer) do
defp parse_fragment(%__MODULE__{} = ref, "/" <> _ = pointer) do
keys = unescaped_ref_segments(pointer)

pointer =
Expand All @@ -45,7 +45,7 @@ defmodule ExJsonSchema.Schema.Ref do
%__MODULE__{ref | fragment: pointer, fragment_pointer?: true}
end

defp parse_fragment(ref, id), do: %__MODULE__{ref | fragment: [id]}
defp parse_fragment(%__MODULE__{} = ref, id), do: %__MODULE__{ref | fragment: [id]}

defp unescaped_ref_segments(ref) do
ref
Expand Down
5 changes: 4 additions & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ defmodule ExJsonSchema.Mixfile do
package: package(),
elixirc_paths: elixirc_paths(Mix.env()),
test_coverage: [tool: ExCoveralls],
preferred_cli_env: [coveralls: :test, dialyzer: :test],
dialyzer: [
plt_add_apps: [:ex_unit]
]
Expand All @@ -29,6 +28,10 @@ defmodule ExJsonSchema.Mixfile do
[extra_applications: []]
end

def cli do
[preferred_envs: [coveralls: :test, dialyzer: :test]]
end

defp deps do
[
{:decimal, "~> 2.0"},
Expand Down
Loading