Skip to content

Commit 42de1c2

Browse files
Responding to review comments
1 parent 76eedfe commit 42de1c2

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

Development/nmos-cpp-node/node_implementation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2023,7 +2023,7 @@ nmos::transport_file_parser make_node_implementation_transport_file_parser()
20232023
return [](const nmos::resource& receiver, const nmos::resource& connection_receiver, const utility::string_t& transport_file_type, const utility::string_t& transport_file_data, slog::base_gate& gate)
20242024
{
20252025
// BCP-007-03: MXL receivers do not use transport_file (non-null data is rejected here when parsed)
2026-
const nmos::transport transport_subclassification(nmos::fields::transport(receiver.data));
2026+
const nmos::transport transport_subclassification{nmos::fields::transport(receiver.data)};
20272027
if (nmos::transports::mxl == nmos::transport_base(transport_subclassification))
20282028
{
20292029
throw std::runtime_error("MXL does not use a transport_file");

Development/nmos/node_resources.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,6 @@ namespace nmos
402402
}
403403

404404
// See https://specs.amwa.tv/is-04/releases/v1.2.0/APIs/schemas/with-refs/flow_audio_raw.html
405-
// (media_type must *not* be nmos::media_types::audio_L(bit_depth); cf. the bit_depth overload)
406405
nmos::resource make_raw_audio_flow(const nmos::id& id, const nmos::id& source_id, const nmos::id& device_id, const nmos::rational& sample_rate, const nmos::media_type& media_type, unsigned int bit_depth, const nmos::settings& settings)
407406
{
408407
using web::json::value;
@@ -422,7 +421,6 @@ namespace nmos
422421
}
423422

424423
// See https://specs.amwa.tv/is-04/releases/v1.2.0/APIs/schemas/with-refs/flow_audio_coded.html
425-
// (media_type must *not* be nmos::media_types::audio_L(bit_depth); cf. nmos::make_raw_audio_flow)
426424
nmos::resource make_coded_audio_flow(const nmos::id& id, const nmos::id& source_id, const nmos::id& device_id, const nmos::rational& sample_rate, const nmos::media_type& media_type, const nmos::settings& settings)
427425
{
428426
using web::json::value;

0 commit comments

Comments
 (0)