Updates based on code review

Author: jonathan-r-thorpe

Development/nmos/connection_api.cpp

@@ -580,8 +580,6 @@ namespace nmos
                     throw std::logic_error("matching IS-04 and IS-05 resources not found");
                 }
 
-                const nmos::transport transport_subclassification(nmos::fields::transport(matching_resource->data));
-
                 // Merge this patch request into a *copy* of the current staged endpoint
                 // so that the merged parameters can be validated against the constraints
                 // before the current values are overwritten.
@@ -642,6 +640,7 @@ namespace nmos
 
                 slog::log<slog::severities::more_info>(gate, SLOG_FLF) << "Validating staged transport parameters against constraints";
 
+                const nmos::transport transport_subclassification(nmos::fields::transport(matching_resource->data));
                 details::validate_staged_constraints(resource->type, nmos::fields::endpoint_constraints(resource->data), nmos::transport_base(transport_subclassification), merged);
 
                 // Perform any final validation

Development/nmos/node_resources.cpp

@@ -421,6 +421,7 @@ namespace nmos
     }
 
     // See https://specs.amwa.tv/is-04/releases/v1.2.0/APIs/schemas/with-refs/flow_audio_coded.html
+    // (media_type must *not* be nmos::media_types::audio_L(bit_depth); cf. nmos::make_raw_audio_flow)
     nmos::resource make_coded_audio_flow(const nmos::id& id, const nmos::id& source_id, const nmos::id& device_id, const nmos::rational& sample_rate, const nmos::media_type& media_type, const nmos::settings& settings)
     {
         using web::json::value;

Development/nmos/node_resources.h

@@ -84,7 +84,6 @@ namespace nmos
 
     // See https://specs.amwa.tv/is-04/releases/v1.2.0/APIs/schemas/with-refs/flow_audio_raw.html
     nmos::resource make_raw_audio_flow(const nmos::id& id, const nmos::id& source_id, const nmos::id& device_id, const nmos::rational& sample_rate, unsigned int bit_depth, const nmos::settings& settings);
-    // (media_type must *not* be nmos::media_types::audio_L(bit_depth); cf. the bit_depth overload)
     nmos::resource make_raw_audio_flow(const nmos::id& id, const nmos::id& source_id, const nmos::id& device_id, const nmos::rational& sample_rate, const nmos::media_type& media_type, unsigned int bit_depth, const nmos::settings& settings);
     nmos::resource make_raw_audio_flow(const nmos::id& id, const nmos::id& source_id, const nmos::id& device_id, const nmos::settings& settings);