Skip to content

Commit c70da56

Browse files
Apply suggestions from code review
Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
1 parent 6a31cab commit c70da56

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

Development/nmos-cpp-node/config.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
// senders, receivers: controls which kinds of sender and receiver are instantiated by the example node
2424
// the values must be an array of unique strings identifying the kinds of 'port', like ["v", "a", "d"], see impl::ports
25-
// for MXL Senders and Receivers, the values must be ["xv", "xa", "xd"]
25+
// for MXL senders and receivers, the values must be like ["xv", "xa", "xd"]
2626
// when omitted, all ports are instantiated
2727
//"senders": ["v", "a", "d"],
2828
//"receivers": ["v", "a", "d"],
@@ -52,7 +52,8 @@
5252
// component_depth: controls the bits per component sample of video flows
5353
//"component_depth": 10,
5454

55-
// video_type: media type of video flows, e.g. "video/raw", "video/jxsv", or "video/v210" for MXL Senders and Receivers, see nmos::media_types
55+
// video_type: media type of video flows, e.g. "video/raw", "video/jxsv" for ST 2110 senders and receivers
56+
// or "video/v210" for MXL senders and receivers, see nmos::media_types
5657
//"video_type": "video/raw",
5758

5859
// channel_count: controls the number of channels in audio sources

Development/nmos/is05_schemas/is05_schemas.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace nmos
77
{
88
namespace is05_schemas
99
{
10-
namespace v1_2_x
10+
namespace v1_2_dev
1111
{
1212
extern const char* activation_schema;
1313
extern const char* sender_stage_schema;

Development/nmos/json_schema.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ namespace nmos
7777
return{ _XPLATSTR("https://github.com/AMWA-TV/is-05/raw/") + tag + _XPLATSTR("/APIs/schemas/") + ref };
7878
}
7979

80-
// See https://github.com/AMWA-TV/is-05/blob/v1.2.x/APIs/schemas/
80+
// See https://github.com/AMWA-TV/is-05/blob/v1.2-dev/APIs/schemas/
8181
namespace v1_2
8282
{
83-
using namespace nmos::is05_schemas::v1_2_x;
84-
const utility::string_t tag(_XPLATSTR("v1.2.x"));
83+
using namespace nmos::is05_schemas::v1_2_dev;
84+
const utility::string_t tag(_XPLATSTR("v1.2-dev"));
8585

8686
const web::uri connectionapi_sender_staged_patch_request_uri = make_schema_uri(tag, _XPLATSTR("sender-stage-schema.json"));
8787
const web::uri connectionapi_receiver_staged_patch_request_uri = make_schema_uri(tag, _XPLATSTR("receiver-stage-schema.json"));

0 commit comments

Comments
 (0)