Exclude out parameters from pass-by-reference diagnostics (#32)

jonathanalgar · web-flow · commit 794ac7fbbe3b · 2025-02-23T00:50:10.000Z
* change

* update tests
diff --git a/src/CustomCode-Analyzer/Analyzer.cs b/src/CustomCode-Analyzer/Analyzer.cs
@@ -887,8 +887,8 @@ ConcurrentDictionary<SyntaxTree, Location> candidateInputSizeLimitDiagnostics
             {
                 foreach (var parameter in methodSymbol.Parameters)
                 {
-                    // Disallow reference-like (ref/out/in) parameters
-                    if (parameter.RefKind is RefKind.Ref or RefKind.Out or RefKind.In)
+                    // Disallow reference-like (ref/in) parameters
+                    if (parameter.RefKind is RefKind.Ref or RefKind.In)
                     {
                         var paramSyntax =
                             parameter.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax()
diff --git a/tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs b/tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs
@@ -1163,10 +1163,6 @@ public void ReadValue(in double number) { }
                     .Diagnostic(DiagnosticIds.ParameterByReference)
                     .WithSpan(5, 22, 5, 35)
                     .WithArguments("value", "UpdateValue"),
-                CSharpAnalyzerVerifier<Analyzer>
-                    .Diagnostic(DiagnosticIds.ParameterByReference)
-                    .WithSpan(6, 19, 6, 34)
-                    .WithArguments("text", "GetValue"),
                 CSharpAnalyzerVerifier<Analyzer>
                     .Diagnostic(DiagnosticIds.ParameterByReference)
                     .WithSpan(7, 20, 7, 36)
@@ -1213,10 +1209,6 @@ public void ReadValue(in double number) { }
                     .Diagnostic(DiagnosticIds.ParameterByReference)
                     .WithSpan(7, 26, 7, 39)
                     .WithArguments("value", "UpdateValue"),
-                CSharpAnalyzerVerifier<Analyzer>
-                    .Diagnostic(DiagnosticIds.ParameterByReference)
-                    .WithSpan(8, 23, 8, 38)
-                    .WithArguments("text", "GetValue"),
                 CSharpAnalyzerVerifier<Analyzer>
                     .Diagnostic(DiagnosticIds.ParameterByReference)
                     .WithSpan(9, 24, 9, 40)

Original file line number	Diff line number	Diff line change
`@@ -887,8 +887,8 @@ ConcurrentDictionary<SyntaxTree, Location> candidateInputSizeLimitDiagnostics`
`887`	`887`	`{`
`888`	`888`	`foreach (var parameter in methodSymbol.Parameters)`
`889`	`889`	`{`
`890`		`- // Disallow reference-like (ref/out/in) parameters`
`891`		`- if (parameter.RefKind is RefKind.Ref or RefKind.Out or RefKind.In)`
	`890`	`+ // Disallow reference-like (ref/in) parameters`
	`891`	`+ if (parameter.RefKind is RefKind.Ref or RefKind.In)`
`892`	`892`	`{`
`893`	`893`	`var paramSyntax =`
`894`	`894`	`parameter.DeclaringSyntaxReferences.FirstOrDefault()?.GetSyntax()`