Fix false positive for UnsupportedTypeMapping on byte array fields (#31)

Author: jonathanalgar

src/CustomCode-Analyzer/Analyzer.cs

@@ -1443,9 +1443,14 @@ private static bool HasIncompatibleDataTypeMapping(ITypeSymbol type, TypedConsta
                 return true;
             }
 
+            // If the type is an array, reconstruct the expected type name ("Byte[]" from type "Byte")
+            string actualTypeName = type is IArrayTypeSymbol arrayType
+                ? arrayType.ElementType.Name + "[]"
+                : type.Name;
+
             // Finally, compare the actual .NET type name with the expected
             // .NET type name from TypeMappingHelper
-            return !type.Name.Equals(expectedDotNetType, StringComparison.OrdinalIgnoreCase);
+            return !actualTypeName.Equals(expectedDotNetType, StringComparison.OrdinalIgnoreCase);
         }
     }
 }

tests/CustomCode-Analyzer.Tests/AnalyzerTests.cs

@@ -1318,6 +1318,24 @@ await CSharpAnalyzerVerifier<Analyzer>.VerifyAnalyzerAsync(
             );
         }
 
+        [TestMethod]
+        public async Task UnsupportedTypeMappingRule_ArrayOfBytes_NoDiagnostic()
+        {
+            var source =
+                @"
+[OSStructure]
+public struct TestStruct
+{
+    [OSStructureField(DataType = OSDataType.BinaryData)]
+    public byte[] RawBytes;
+}";
+            await CSharpAnalyzerVerifier<Analyzer>.VerifyAnalyzerAsync(
+                source,
+                TestContext,
+                skipSDKreference: false
+            );
+        }
+
         // --------------- MissingPublicImplementationRule (OS-ELG-MODL-05018) --------
         [TestMethod]
         public async Task MissingPublicImplementationRule_InGlobalScope_ReportsWarning()