Cleanup deployment workflow and revert chaos changes#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all Terraform-related steps from the GitHub Actions workflows and updates deployment logic to use static secret values instead of Terraform outputs. Additionally, it simplifies the validation workflow to only run Python linting. There is also a minor bug fix in the API and a configuration improvement for Azure authentication in Terraform providers.
CI/CD Workflow Changes:
deploy.ymlandvalidate.ymlworkflows, making deployments rely solely on pre-provisioned infrastructure and static secrets. [1] [2]deploy.ymlnow use GitHub secrets (such asAZURE_RESOURCE_GROUP,ACR_NAME,CONTAINER_APP_NAME, etc.) directly for resource names and configuration, instead of dynamically reading them from Terraform outputs. [1] [2] [3]validatetolint, and now only runs Python linting withruffon the API codebase. All Terraform format and validation checks have been removed.Infrastructure as Code Configuration:
infra/providers.tfnow explicitly enables OIDC authentication withuse_oidc = truefor bothazurermandazapiproviders, improving security and compatibility with GitHub Actions.API Bug Fix:
build_line_item_summaryinorders.pyto use the correct keyunit_priceinstead ofpricewhen calculating line item totals.