Skip to content

Add explanatory comments to empty certificate validation methods #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add explanatory comments to empty certificate validation methods #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/main/java/land/oras/auth/HttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,22 +805,34 @@
}

@Override
public void checkClientTrusted(X509Certificate[] chain, String authType) {}
public void checkClientTrusted(X509Certificate[] chain, String authType) {
// Intentionally empty: insecure trust manager that accepts all client certificates
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType) {}
public void checkServerTrusted(X509Certificate[] chain, String authType) {

Check failure on line 813 in src/main/java/land/oras/auth/HttpClient.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Enable server certificate validation on this SSL/TLS connection. 


See more on https://sonarcloud.io/project/issues?id=jonesbusy_oras-java&issues=AZ617EyZJPCg-Y0ew-dI&open=AZ617EyZJPCg-Y0ew-dI&pullRequest=6

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarQube Cloud
// Intentionally empty: insecure trust manager that accepts all server certificates
}

@Override
public void checkClientTrusted(X509Certificate[] chain, String authType, Socket socket) {}
public void checkClientTrusted(X509Certificate[] chain, String authType, Socket socket) {

Check failure on line 818 in src/main/java/land/oras/auth/HttpClient.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Enable server certificate validation on this SSL/TLS connection. 


See more on https://sonarcloud.io/project/issues?id=jonesbusy_oras-java&issues=AZ617EyZJPCg-Y0ew-dJ&open=AZ617EyZJPCg-Y0ew-dJ&pullRequest=6

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarQube Cloud
// Intentionally empty: insecure trust manager that accepts all client certificates
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType, Socket socket) {}
public void checkServerTrusted(X509Certificate[] chain, String authType, Socket socket) {
// Intentionally empty: insecure trust manager that accepts all server certificates
}

@Override
public void checkClientTrusted(X509Certificate[] chain, String authType, SSLEngine engine) {}
public void checkClientTrusted(X509Certificate[] chain, String authType, SSLEngine engine) {

Check failure on line 828 in src/main/java/land/oras/auth/HttpClient.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Enable server certificate validation on this SSL/TLS connection. 


See more on https://sonarcloud.io/project/issues?id=jonesbusy_oras-java&issues=AZ617EyZJPCg-Y0ew-dK&open=AZ617EyZJPCg-Y0ew-dK&pullRequest=6

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarQube Cloud
// Intentionally empty: insecure trust manager that accepts all client certificates
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType, SSLEngine engine) {}
public void checkServerTrusted(X509Certificate[] chain, String authType, SSLEngine engine) {

Check failure on line 833 in src/main/java/land/oras/auth/HttpClient.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Enable server certificate validation on this SSL/TLS connection. 


See more on https://sonarcloud.io/project/issues?id=jonesbusy_oras-java&issues=AZ617EyZJPCg-Y0ew-dL&open=AZ617EyZJPCg-Y0ew-dL&pullRequest=6

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarQube Cloud
// Intentionally empty: insecure trust manager that accepts all server certificates
}
}

/**
Expand Down