Skip to content

feat: dispatch-parity quality improvements#162

Merged
jongio merged 3 commits into
mainfrom
quality/dispatch-parity
Mar 16, 2026
Merged

feat: dispatch-parity quality improvements#162
jongio merged 3 commits into
mainfrom
quality/dispatch-parity

Conversation

@jongio
Copy link
Copy Markdown
Owner

@jongio jongio commented Mar 15, 2026

Dispatch-Parity Quality Improvements

Brings azd-app CI/CD and code quality to parity with jongio/dispatch.

CI/CD & Security

  • SHA-pinned all GitHub Actions to immutable commit SHAs
  • Added CODEOWNERS with @jongio
  • Added CodeQL security scanning workflow
  • Added govulncheck vulnerability scanning workflow
  • Added Dependabot for Go modules and GitHub Actions
  • Added cosign code signing and SBOM generation to release workflow
  • Added concurrency control to CI workflows

Code Quality

  • Upgraded golangci-lint config to proper v2 format (30+ linters)
  • Migrated from v1 config format (settings were silently ignored) to proper v2 nested format
  • Added deadcode detection, gofumpt formatting, cross-GOOS linting to Magefile
  • Fixed 404 lint issues across 86+ files (doc comments, misspell, unparam, bodyclose, nilerr, gosec permissions, goconst, prealloc, noctx context propagation, wastedassign, exhaustive, dupl)
  • Added README badges (CI, Release, Go Report Card, Go Reference)

Files Changed

141 files changed, 1499 insertions(+), 830 deletions(-)

jongio and others added 2 commits March 15, 2026 06:44
Replace buzzwords (supercharge, seamlessly, game-changer, Leverage)
with concrete, specific language.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace buzzword copy with concrete descriptions:
- 'powerful log viewing' -> 'log viewing'
- 'enabling intelligent debugging' -> 'for debugging'
- 'The ultimate guide...fun examples and pro tips' -> factual description
- 'production-grade reliability and observability features' -> 'configurable checks, streaming output, and failure alerts'
- 'comprehensive tour' -> 'tour'
- 'Take a comprehensive tour' -> 'Walk through all features step by step'

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jongio jongio force-pushed the quality/dispatch-parity branch from d93d600 to 36b8b71 Compare March 15, 2026 13:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 15, 2026

🚀 Website Preview

Your PR preview was available here.

Preview has been cleaned up as the PR was closed.

github-actions Bot added a commit that referenced this pull request Mar 15, 2026
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 57.00165% with 261 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.82%. Comparing base (e4b7578) to head (e8c1e38).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/internal/healthcheck/monitor.go 25.00% 21 Missing ⚠️
cli/src/internal/azure/standalone_logs.go 4.76% 20 Missing ⚠️
cli/src/cmd/app/commands/generate.go 46.87% 17 Missing ⚠️
cli/src/cmd/app/commands/logs.go 41.37% 15 Missing and 2 partials ⚠️
cli/src/internal/installer/installer.go 29.41% 12 Missing ⚠️
cli/src/internal/testing/orchestrator.go 64.51% 11 Missing ⚠️
cli/src/internal/dashboard/azure_logs_health.go 47.05% 9 Missing ⚠️
cli/src/internal/docker/exec.go 10.00% 9 Missing ⚠️
cli/src/internal/dashboard/azure_logs_tables.go 0.00% 8 Missing ⚠️
cli/src/internal/service/detector_frameworks.go 69.23% 8 Missing ⚠️
... and 50 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   54.86%   54.82%   -0.05%     
==========================================
  Files         147      147              
  Lines       22283    22328      +45     
==========================================
+ Hits        12226    12241      +15     
- Misses       9286     9312      +26     
- Partials      771      775       +4     
Flag Coverage Δ
unittests 54.82% <57.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cli/src/cmd/app/commands/add.go 33.63% <100.00%> (+0.60%) ⬆️
cli/src/cmd/app/commands/deps.go 41.80% <ø> (ø)
cli/src/cmd/app/commands/info.go 75.82% <100.00%> (ø)
cli/src/internal/azure/bicep.go 98.66% <100.00%> (ø)
cli/src/internal/azure/diagnostic_engine.go 70.58% <ø> (ø)
cli/src/internal/azure/diagnostics.go 24.15% <ø> (ø)
cli/src/internal/azure/discovery.go 33.68% <100.00%> (ø)
cli/src/internal/azure/loganalytics.go 30.63% <100.00%> (ø)
cli/src/internal/azure/realtime.go 69.20% <ø> (-0.64%) ⬇️
cli/src/internal/azure/validator_appservice.go 70.87% <100.00%> (ø)
... and 78 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jongio jongio force-pushed the quality/dispatch-parity branch from 36b8b71 to 524a85e Compare March 15, 2026 13:54
github-actions Bot added a commit that referenced this pull request Mar 15, 2026
@jongio jongio force-pushed the quality/dispatch-parity branch from 524a85e to 079f890 Compare March 15, 2026 20:16
github-actions Bot added a commit that referenced this pull request Mar 15, 2026
- Pin all GitHub Actions to full commit SHAs
- Add CODEOWNERS file
- Add Dependabot for go modules and github-actions
- Add concurrency control to CI/PR workflows
- Add CodeQL security scanning workflow
- Add govulncheck vulnerability scanning workflow
- Standardize golangci-lint config with 30+ linters
- Add dispatch-level linters (errname, exhaustive, forcetypeassert, etc.)
- Add gofumpt strict formatting checks
- Add deadcode detection
- Add cosign code signing to release workflow
- Add SBOM generation (SPDX + CycloneDX) to release workflow
- Add comprehensive README badges (CI, CodeQL, Go Report Card, etc.)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jongio jongio force-pushed the quality/dispatch-parity branch from 079f890 to e8c1e38 Compare March 15, 2026 20:23
github-actions Bot added a commit that referenced this pull request Mar 15, 2026
@jongio jongio merged commit 70dde10 into main Mar 16, 2026
15 of 16 checks passed
@jongio jongio deleted the quality/dispatch-parity branch March 16, 2026 16:10
github-actions Bot added a commit that referenced this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants