perf: circular buffer, parallel RPC, and observer cleanup#248
Merged
Conversation
- Replace O(n) slice shifting with O(1) ring buffer in LogBuffer, localLogRing, and localAzureLogRing (fixes #211) - Parallelize per-service RPC calls in GetAzureLogs using errgroup for concurrent fan-out (fixes #212) - Add astro:before-swap cleanup for MutationObserver and setInterval in Lightbox, Screenshot, and DashboardCarousel components (fixes #214)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance improvements
1. O(1) circular buffer for log buffers
Replace O(n) slice shifting (
buf = append(buf[:0], buf[1:]...)) with a proper ring buffer using head/count index tracking. Affected types:service.LogBuffer: main log buffer used by all serviceslocalLogRinginrpc/logs.go: streaming log ringlocalAzureLogRinginrpc/azure_stream.go: Azure streaming ringFixes #211
2. Parallel per-service RPC calls in GetAzureLogs
The dashboard client's
GetAzureLogsnow launches concurrent RPCs (viaerrgroup) when multiple services are requested, instead of issuing them sequentially. Single-service requests take a fast path with no goroutine overhead.Fixes #212
3. MutationObserver and timer cleanup on Astro page transitions
Added
astro:before-swaphandlers (with{ once: true }) to disconnect MutationObservers, remove media query listeners, and clear autoplay timers before Astro swaps the DOM. Affected components:Lightbox.astro: disconnects observer, removes window globalsScreenshot.astro: disconnects observer, removes media query listenerDashboardCarousel.astro: clears autoplay interval timerFixes #214