fix: address bugs, goroutine leak, null-safety, and deprecated APIs#249
Merged
Conversation
- Fix #189: Add Image field to ServiceRuntime struct; store container image in the correct field instead of misusing Command field - Fix #188: Always call initializeValidators in RunDiagnostics regardless of workspace ID (constructors handle empty workspace gracefully) - Fix #210: Add scanner.Err() checks after scanner loops in collectContainerLogs, collectStreamLogs, and collectFunctionsStreamLogs - Fix #207: Add context parameter to sendWithBackpressure to prevent goroutine leak on stream send timeout when client disconnects - Fix #204: Remove deprecated execCommand clipboard fallback; use navigator.clipboard.writeText exclusively - Fix #203: Replace Function constructor with standard dynamic import using vite-ignore annotation for pagefind - Fix #202: Cache index.html content at startup in SPA fallback handler; eliminate per-request file open/read - Fix #216: Resolve 8 TypeScript null-safety errors reported by astro check in Search.astro and screenshot-capture.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses 8 bug fix issues:
Imagefield toServiceRuntimestruct and updated detector/runner to use it instead of misusing theCommandfieldinitializeValidatorsis always called inRunDiagnostics(constructors gracefully handle empty workspace ID)scanner.Err()checks after all scanner loops incollectContainerLogs,collectStreamLogs, andcollectFunctionsStreamLogscontext.Contextparameter so the background goroutine exits when the stream context is cancellednavigator.clipboard.writeTextexclusivelyFunction('return import(...)')with nativeimport()using/* @vite-ignore */annotationindex.htmlat startup viaos.ReadFileand serve from memory on each fallback requestrule.textContentin local variable for closure safety