fix: wave 1 - fix failing test, repo health, and git cleanup#276
Merged
Conversation
- Fix TestLogBuffer_GetLogsWithContext panic by using Add() instead of direct struct initialization (ring buffer count was 0) (#273) - Fix dependabot gomod directory from / to /cli (#272) - Add dates to CHANGELOG 0.4.0 and 0.5.0 entries (#272) - Remove stale package-lock.json from cli/dashboard (#272) - Delete stale patrol/refactoring local branch (#266) Closes #273, #272, #266 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Format 5 Go files with gofmt -w -s - Remove unused zerolog dependency via go mod tidy - Regenerate pnpm-lock.yaml to fix overrides config mismatch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Website Preview
Preview has been cleaned up as the PR was closed. |
- Format 3 more Go files (logbuffer_context_test, parser_test, orchestrator) - Fix TestContainerRuntimeDetection: check runtime.Image instead of runtime.Command (image is stored in Image field, not Command) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 1: Quick Isolated Fixes
Issues Resolved
Changes
ewTestLogBuffer()\ helper that properly initializes the ring buffer via \Add()\ instead of direct struct initialization (which left \count==0, causing \linearize()\ to return nil and panics)
Note
The stale \patrol/refactoring\ remote branch should also be deleted: \git push origin --delete patrol/refactoring\
Closes #273, #272, #266