refactor: wave 4 - consolidate duplicates, centralize parsing, extract helpers#279
Merged
Conversation
…t helpers Code smells (#274): - Reduce ServiceInfo duplication across 5 files - Centralize azure.yaml parsing via service.ParseAzureYaml - Introduce DetectedProjects struct for 3-parameter data clump - Extract runReqsFix into cohesive helper methods - Replace parallel switch statements in query_builder.go with config map Architecture (#265): - Extract shared Azure log level conversion to eliminate duplication - Remove global mutable cmdOrchestrator, make injectable Closes #274, #265 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
32ced2a to
b4dcc84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 4: Refactoring
Issues Resolved
Code Smell Fixes (#274)
odeProjects, \pythonProjects, \dotnetProjects) with a single struct
Architecture Fixes (#265, bounded scope)
Deferred (too risky for automated changes)
Closes #274, #265