refactor: split god modules into focused files#287
Merged
Conversation
Split 3 large files (>500 lines) into smaller, single-responsibility modules: rpc/logs.go (833 -> 398 lines): - logs_store.go: store interfaces + LogsStoreFuncs adapter (123 lines) - logs_ring.go: localLogRing buffer implementation (85 lines) - logs_proto.go: proto conversion helpers (170 lines) commands/reqs.go (885 -> 260 lines): - reqs_checker.go: PrerequisiteChecker + command validation (303 lines) - reqs_version.go: version parsing/comparison utilities (126 lines) - reqs_fix.go: fix runner flow (213 lines) commands/run.go (769 -> 328 lines): - run_orchestration.go: service execution/monitoring lifecycle (347 lines) - run_hooks.go: hook execution/conversion (112 lines) All files now under 500 lines. No behavioral changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits 3 files exceeding 500 lines into single-responsibility modules. All files now under 500 lines. No behavioral changes - pure mechanical split with proper imports.
rpc/logs.go (833 -> 398 lines): extracted store interfaces, ring buffer, and proto helpers
commands/reqs.go (885 -> 260 lines): extracted checker, version utils, and fix runner
commands/run.go (769 -> 328 lines): extracted orchestration lifecycle and hooks
Build, lint, and tests all pass.