[enh] Allow to define another attribute as primary mail source#94
Open
zamentur wants to merge 1 commit into
Open
[enh] Allow to define another attribute as primary mail source#94zamentur wants to merge 1 commit into
zamentur wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In yunohost LDAP database, sometimes we do not want to use the first mail attribute as discourse primary mail.
Solution
Allow to configure which mail attribute use in priority for discourse primary mail (and fallback on mail if empty).
This PR update the primary mail with LDAP db at each authentication (in the current base code, it was only set at creation, and after user could edit manually the primary mail).
Note: it's a POC, we think more thinking and discussion are needed to create a good use case.
This PR extends #82
Status
Tested manually