Feature/history navigation#63
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| const handleInputKeyDown = (event: KeyboardEvent<HTMLInputElement>) => { | ||
| if(!onInput) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
@leonardo3130 Was this added on purpose? Looks like it broke entering chars w/i terminal.
There was a problem hiding this comment.
Yes, my fault. It wanted e.preventDefault() to run only for Arrow keys, somehow i put it in the wrong place.
Can I remove it from there and put it at the correct place?
I didn't find instructions on how to try the component locally, so I relied on tests. I am sorry
There was a problem hiding this comment.
I solved the issue by doing event.preventDefault(); only arrow keys and enter. Let me know if you want me to submit a PR. Before submitting I'd prefer to understand how to run the demo locally (if possible).
I think this would be also a good information to put in the README file.
2 participants
Fixes #35