Skip to content

fix typing event bug#65

Merged
jonmbake merged 2 commits into
jonmbake:masterfrom
leonardo3130:fix/fix-typing-bug
Nov 29, 2025
Merged

fix typing event bug#65
jonmbake merged 2 commits into
jonmbake:masterfrom
leonardo3130:fix/fix-typing-bug

Conversation

@leonardo3130

Copy link
Copy Markdown
Contributor

Fixes typing event bug accidentally introduced in #63 .

Important

I was not able to run the demo locally to check if other bugs are happening, but it should be okay.
@jonmbake if you know how to run the demo locally for testing/debugging please let me know so I can be sure to
not create additional issues.

@jonmbake

Copy link
Copy Markdown
Owner

@leonardo3130 To test locally:

npm run build
cd docs/demo
open index.html

@leonardo3130

Copy link
Copy Markdown
Contributor Author

@jonmbake I fixed another small bug, always related to event.preventDefault(). Then I also set cursor position to be at the end when navigating to a new element of the history. Let me know if something needs to be changed :)

@jonmbake jonmbake merged commit 541d0e9 into jonmbake:master Nov 29, 2025
2 checks passed
@jonmbake

Copy link
Copy Markdown
Owner

@leonardo3130 There are a couple of other minor tweaks we may want to make in the future:

  1. Input is not cleared when clicking down arrow while navigating history on first item is active.
  2. Input is lost when navigating history.

The core functionality works; I'll create a separate issue for these minor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants